Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added periodical for depstat #22200

Merged
merged 3 commits into from
May 17, 2021
Merged

added periodical for depstat #22200

merged 3 commits into from
May 17, 2021

Conversation

RinkiyaKeDad
Copy link
Member

Signed-off-by: RinkiyaKeDad [email protected]

Added a periodical job for depstat based on the previous one. Please let me know if name, description or something else needs to be changed.

/assign @dims

Signed-off-by: RinkiyaKeDad <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @RinkiyaKeDad. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/config Issues or PRs related to code in /config area/conformance Issues or PRs related to kubernetes conformance tests area/jobs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 17, 2021
@k8s-ci-robot k8s-ci-robot requested review from cheftako and oomichi May 17, 2021 12:56
@dims
Copy link
Member

dims commented May 17, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2021
@RinkiyaKeDad
Copy link
Member Author

Test failing with the error:

ERROR: /home/prow/go/src/github.com/kubernetes/test-infra/config/tests/testgrids/BUILD.bazel:25:8: Executing genrule //config/tests/testgrids:testgrid_config failed (Exit 1)
6274
2021/05/17 13:25:10 FAIL: couldn't load prow config: error unmarshaling config/jobs/kubernetes/sig-arch/kubernetes-depstat-periodical.yaml: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal object into Go struct field JobConfig.periodics of type []config.Periodic

I think it's because the way I specified it is incorrect. Will try the way it has been done here.

Signed-off-by: RinkiyaKeDad <[email protected]>
@RinkiyaKeDad
Copy link
Member Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 17, 2021
Copy link
Member Author

@RinkiyaKeDad RinkiyaKeDad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dims it's all green but I have some doubts on if I've done this correctly or not.

Comment on lines 10 to 11
always_run: false
optional: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these two needed here? I didn't see them in this periodical?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need these 2

@RinkiyaKeDad RinkiyaKeDad requested a review from dims May 17, 2021 14:41
@dims
Copy link
Member

dims commented May 17, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, RinkiyaKeDad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7522b08 into kubernetes:master May 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 17, 2021
@k8s-ci-robot
Copy link
Contributor

@RinkiyaKeDad: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubernetes-depstat-periodical.yaml using file config/jobs/kubernetes/sig-arch/kubernetes-depstat-periodical.yaml

In response to this:

Signed-off-by: RinkiyaKeDad [email protected]

Added a periodical job for depstat based on the previous one. Please let me know if name, description or something else needs to be changed.

/assign @dims

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/conformance Issues or PRs related to kubernetes conformance tests area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants