Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golang canary jobs for kubernetes/kubernetes #23247

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

justaugustus
Copy link
Member

  • Enable GH report for kubernetes/kubernetes presubmits
  • Remove release-branch presubmits
  • Add pull-kubernetes-unit-go-canary

From @liggitt in kubernetes/kubernetes#103692 (comment):

do we have canary versions of pull-kubernetes-dependencies / pull-kubernetes-verify / pull-kubernetes-integration / pull-kubernetes-unit running with go1.17rc2 so we can have confidence all CI is actually green on go1.17 prior to merge?

Part of go1.17 pre-release bump: kubernetes/release#2169, kubernetes/kubernetes#103692

Background on go canaries: #21107, #21110, kubernetes/kubernetes#98572

/assign @spiffxp @dims @BenTheElder
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 13, 2021
@BenTheElder
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2021
@liggitt
Copy link
Member

liggitt commented Aug 13, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5452e6d into kubernetes:master Aug 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 13, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key 1.21.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.21.yaml
  • key 1.22.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.22.yaml
  • key dependencies.yaml using file config/jobs/kubernetes/sig-testing/dependencies.yaml
  • key integration.yaml using file config/jobs/kubernetes/sig-testing/integration.yaml
  • key make-test.yaml using file config/jobs/kubernetes/sig-testing/make-test.yaml
  • key verify.yaml using file config/jobs/kubernetes/sig-testing/verify.yaml

In response to this:

  • Enable GH report for kubernetes/kubernetes presubmits
  • Remove release-branch presubmits
  • Add pull-kubernetes-unit-go-canary

From @liggitt in kubernetes/kubernetes#103692 (comment):

do we have canary versions of pull-kubernetes-dependencies / pull-kubernetes-verify / pull-kubernetes-integration / pull-kubernetes-unit running with go1.17rc2 so we can have confidence all CI is actually green on go1.17 prior to merge?

Part of go1.17 pre-release bump: kubernetes/release#2169, kubernetes/kubernetes#103692

Background on go canaries: #21107, #21110, kubernetes/kubernetes#98572

/assign @spiffxp @dims @BenTheElder
cc: @kubernetes/release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants