Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images/alpine: Build for ppc64le #23276

Merged
merged 1 commit into from
Aug 18, 2021
Merged

images/alpine: Build for ppc64le #23276

merged 1 commit into from
Aug 18, 2021

Conversation

deepsm007
Copy link
Contributor

@deepsm007 deepsm007 commented Aug 17, 2021

This commit adds a Google Cloud Build definition for building alpine
ppc64le images and pushing them as a manifest list together with their
ppc64le counterparts.

/cc @mkumatag
/cc @stevekuznetsov

rel: #16588

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 17, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @deepsm007!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 17, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @deepsm007. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 17, 2021
@deepsm007 deepsm007 changed the title Build for ppc64le images/alpine: Build for ppc64le Aug 17, 2021
@deepsm007 deepsm007 marked this pull request as ready for review August 17, 2021 17:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2021
@mkumatag
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2021
@mkumatag
Copy link
Member

mkumatag commented Aug 17, 2021

@deepsm007 please sign the cla

@mkumatag
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2021
@deepsm007
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 18, 2021
@mkumatag
Copy link
Member

/assign @fejta @BenTheElder

Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @chaodaiG

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit e6fa606 into kubernetes:master Aug 18, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 18, 2021
@deepsm007
Copy link
Contributor Author

deepsm007 commented Aug 18, 2021

@chaodaiG Seems something failed and I do not see the latest image

@chaodaiG
Copy link
Contributor

it's pushed by postsubmit job: https://prow.k8s.io/?repo=kubernetes%2Ftest-infra&type=postsubmit

more specifically https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-push-alpine/1428075756864409600

@chaodaiG
Copy link
Contributor

failed 3/4 in most recent runs https://prow.k8s.io/job-history/gs/kubernetes-jenkins/logs/post-test-infra-push-alpine, sounds like flaky to me

@mkumatag
Copy link
Member

failed 3/4 in most recent runs https://prow.k8s.io/job-history/gs/kubernetes-jenkins/logs/post-test-infra-push-alpine, sounds like flaky to me

Seems to be flaky n/w issue to me, not sure if someone can help us retrigger that post submit job for us.?

@chaodaiG
Copy link
Contributor

Triggered: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-push-alpine/1428119503090225152

@mkumatag
Copy link
Member

Triggered: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-push-alpine/1428119503090225152

I see job is successful, and image is also available for ppc64le platform:

$ manifest-tool inspect gcr.io/k8s-prow/alpine:v20210818-e6fa606
Name:   gcr.io/k8s-prow/alpine:v20210818-e6fa606 (Type: application/vnd.docker.distribution.manifest.list.v2+json)
Digest: sha256:c18ca399a9f0488a1c2401d4eaa5aa776f976bfc5741b1763439e546e1efc38b
 * Contains 3 manifest references:
1    Mfst Type: application/vnd.docker.distribution.manifest.v2+json
1       Digest: sha256:0357fb2e591bce72c2418d2f29b2b0803cc299f99612823f77cb79ecffd073eb
1  Mfst Length: 738
1     Platform:
1           -      OS: linux
1           - OS Vers:
1           - OS Feat: []
1           -    Arch: amd64
1           - Variant:
1           - Feature:
1     # Layers: 2
         layer 1: digest = sha256:29291e31a76a7e560b9b7ad3cada56e8c18d50a96cca8a2573e4f4689d7aca77
         layer 2: digest = sha256:d8b0fef36ee8776d54c12fed24e6eae5e3ad0253ca18dca4e57e90f1d5c85eda

2    Mfst Type: application/vnd.docker.distribution.manifest.v2+json
2       Digest: sha256:4b3f2324bfc15c3bdc73014b34123f0a521d4b1b4d380297a3629df7d269d965
2  Mfst Length: 738
2     Platform:
2           -      OS: linux
2           - OS Vers:
2           - OS Feat: []
2           -    Arch: arm64
2           - Variant:
2           - Feature:
2     # Layers: 2
         layer 1: digest = sha256:fd3acdcea5682abced546ec19fb6ebee725c5184e5d91614c469c0a79e67f2d0
         layer 2: digest = sha256:c870bdb2572e9e2969fa459f01b8acf3a69083113b44c807043920679525b54a

3    Mfst Type: application/vnd.docker.distribution.manifest.v2+json
3       Digest: sha256:9a142ec3c9e51d47e762f70bdcdaf93893b0e6d3aeee27a9818e377ccd40eb10
3  Mfst Length: 738
3     Platform:
3           -      OS: linux
3           - OS Vers:
3           - OS Feat: []
3           -    Arch: ppc64le
3           - Variant:
3           - Feature:
3     # Layers: 2
         layer 1: digest = sha256:0ff902055236f70c4694c806877243e1dd52c513825a2a3ecc7eba8f5202acc8
         layer 2: digest = sha256:6b6905b8b6cc973d62fcdf70a92e8ef588196f2c5ae9da3a0551528324419683

$ docker pull --platform linux/ppc64le gcr.io/k8s-prow/alpine:v20210818-e6fa606
v20210818-e6fa606: Pulling from k8s-prow/alpine
0ff902055236: Pull complete
6b6905b8b6cc: Pull complete
Digest: sha256:c18ca399a9f0488a1c2401d4eaa5aa776f976bfc5741b1763439e546e1efc38b
Status: Downloaded newer image for gcr.io/k8s-prow/alpine:v20210818-e6fa606
gcr.io/k8s-prow/alpine:v20210818-e6fa606
$ docker run -ti gcr.io/k8s-prow/alpine:v20210818-e6fa606
WARNING: The requested image's platform (linux/ppc64le) does not match the detected host platform (linux/amd64) and no specific platform was requested
/ # uname -a
Linux 7bca4d763d3e 5.10.25-linuxkit #1 SMP Tue Mar 23 09:27:39 UTC 2021 ppc64le Linux
/ #

@deepsm007 lets bump the baseimage gcr.io/k8s-prow/alpine:v20210818-e6fa606 wherever required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants