Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSI in GKE master periodics. Attempt #2 #24356

Merged

Conversation

mborsz
Copy link
Member

@mborsz mborsz commented Nov 15, 2021

Reverts #24352

Let's try to enable it again. With kubernetes/perf-tests#1938 it may work.

/assign @tosi3k
/cc @leiyiz

@k8s-ci-robot
Copy link
Contributor

@mborsz: GitHub didn't allow me to request PR reviews from the following users: leiyiz.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Reverts #24352

Let's try to enable it again. With kubernetes/perf-tests#1938 it may work.

/assign @tosi3k
/cc @leiyiz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 15, 2021
@tosi3k
Copy link
Member

tosi3k commented Nov 15, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
@mborsz mborsz changed the title Revert "Revert "Use CSI in GKE master periodics."" Use CSI in GKE master periodics. Attempt #2 Nov 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6fbe005 into kubernetes:master Nov 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 15, 2021
@k8s-ci-robot
Copy link
Contributor

@mborsz: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-scalability-presets.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml

In response to this:

Reverts #24352

Let's try to enable it again. With kubernetes/perf-tests#1938 it may work.

/assign @tosi3k
/cc @leiyiz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mborsz
Copy link
Member Author

mborsz commented Nov 15, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants