-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ulimit
error in krte
image
#31782
Fix ulimit
error in krte
image
#31782
Conversation
Hi @oliver-goetz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: listx, oliver-goetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks! we also don't want docker 25.0 yet until 25.0.1 is out because 25.0.0 has at least one other known bug fixed in 25.0.1 that affects kind usage. might want to pin to 24.x for a bit we also will need to fix images/bootstrap => kubekins-e2e |
krte
image is broken withdocker-ce 25.0.0
and fails when executing anulimit
command (see my comment).This PR implements a fix for it similar to how we did it for our own version of
krte
image (gardener/ci-infra#1108).The idea for the fix was taken from a docker issue: docker/cli#4807 (comment)