Update k8s-staging-test-infra GCR images as needed #31873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: k8s-infra-ci-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/artifacts
k8s-infra-ci-robot
force-pushed
the
prowjobs-autobump
branch
from
bf19ca0 to
e39a610
Compare
k8s-infra-ci-robot
force-pushed
the
prowjobs-autobump
branch
from
e39a610 to
f890b11
Compare
k8s-infra-ci-robot
force-pushed
the
prowjobs-autobump
branch
from
f890b11 to
0174ea3
Compare
k8s-ci-robot
added
area/conformance
k8s-infra-ci-robot
force-pushed
the
prowjobs-autobump
branch
2 times, most recently
from
d1bcfac to
a273a70
Compare
…nd k8s-staging-test-infra AR images No gcr.io/k8s-testimages/ changes. Multiple distinct gcr.io/k8s-staging-test-infra changes: Commits | Dates | Images --- | --- | --- kubernetes/test-infra@8b9fd88...d8632cc | 2023‑12‑08 → 2024‑02‑07 | kubekins-e2e(test-infra) kubernetes/test-infra@9db6d59...d8632cc | 2024‑01‑30 → 2024‑02‑07 | kubekins-e2e(1.26), kubekins-e2e(1.27), kubekins-e2e(1.28), kubekins-e2e(1.29), kubekins-e2e(experimental), kubekins-e2e(go-canary), kubekins-e2e(master) kubernetes/test-infra@23c1cae...d8632cc | 2024‑01‑31 → 2024‑02‑07 | krte(1.26), krte(1.27), krte(1.28), krte(1.29), krte(experimental), krte(master) No us-central1-docker.pkg.dev/k8s-staging-test-infra/images changes.
k8s-infra-ci-robot
force-pushed
the
prowjobs-autobump
branch
from
a273a70 to
2bf070c
Compare
|
/cc @dims |
dims
added
the
skip-review
|
@k8s-infra-ci-robot: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
So, this broke a lot of important CI jobs (like multiple k/k presubmits) and should be rolled back, in the future can the human merging these please be on hand to watch for and mitigate issues like this? #31889 |
@airbornepony can confirm but IIRC we also auto-apply the skip-review label without human interaction every 3 hours (or some other periodic job schedule). So if we want human checks after the merge every time we would need to disable that periodic job also. |
Those are for prow itself, right? AFAIK that's been pretty stable and oncall has been covering any issues (Thank you!) For the test images, we have to watch out because the "api surface" is huge and used across tons of jobs (efficient, but also high risk), so we rely a bit on reacting to users highlighting breakage, and sig testing is a bit light on bandwidth to work on these images. |
Ah, I keep forgetting this. Yes.
Ack |
|
This is probably why. |
|
we should be out of the woods - landed and watching #31928 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No gcr.io/k8s-testimages/ changes.
Multiple distinct gcr.io/k8s-staging-test-infra changes:
No us-central1-docker.pkg.dev/k8s-staging-test-infra/images changes.
/cc @listx