-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump golang to 1.22 for Kueue #32301
Conversation
/assign @tenzen-y @alculquicondor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check if the kubekins includes Go 1.22?
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20240311-b09cdeb92c-master |
I posted on #sig-testing and opened up the PR in Kueue to see. https://github.com/kubernetes/test-infra/blob/master/images/kubekins-e2e-v2/variants.yaml It looks like it is supported but not sure of this image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubekins does indeed support 1.22 There were a few things that broke in the past due to the automatic upgrade. |
Thank you for confirmations! |
@kannon92: Updated the
In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.