Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable pull-community-tempelis-check as discussed with slack admins #32946

Merged
merged 2 commits into from
Jul 10, 2024
Merged

disable pull-community-tempelis-check as discussed with slack admins #32946

merged 2 commits into from
Jul 10, 2024

Conversation

BenTheElder
Copy link
Member

leave a stubbed in rough template for what a replacement job can look like

update job migration TODO list

@BenTheElder
disable pull-community-tempelis-check as discussed with slack admins
5708497 
leave a stubbed in rough template for what a replacement job can look like
@BenTheElder
update cluster migration todo
a0db166
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and wojtek-t July 10, 2024 19:56
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 10, 2024
@jberkus
Copy link
Contributor

jberkus commented Jul 10, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, jberkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BenTheElder
BenTheElder commented Jul 10, 2024
View reviewed changes
config/jobs/kubernetes/community/community-presubmit.yaml
# testgrid-dashboards: sig-contribex-slack-infra
# spec:
# containers:
# - image: gcr.io/k8s-staging-slack-infra/tempelis:v20200909-1eb97f5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also TODO: we should promote the tempelis image and pull through registry.k8s.io?

that gets this job ahead of GCR => AR migration and gives us more flexibility on cost of serving it / clouds we run the workload from (not high priority, but best practice)

@BenTheElder
Copy link
Member Author

/retest

@BenTheElder
Copy link
Member Author

BenTheElder commented Jul 10, 2024 •
edited
Loading

(job scheduling timeout https://kubernetes.slack.com/archives/CCK68P2Q2/p1720637247581549)

@BenTheElder BenTheElder mentioned this pull request Jul 10, 2024
Closed
4 tasks
@k8s-ci-robot k8s-ci-robot merged commit 929eb78 into kubernetes:master Jul 10, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key community-presubmit.yaml using file config/jobs/kubernetes/community/community-presubmit.yaml

In response to this:

leave a stubbed in rough template for what a replacement job can look like

update job migration TODO list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder BenTheElder deleted the tempelis-migrated branch July 10, 2024 21:31
@BenTheElder BenTheElder mentioned this pull request Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@jberkus jberkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @jberkus @k8s-ci-robot