Respect conditional runs for children pjs #4586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/L
|
/area prow |
spxtr
reviewed
Sep 18, 2017
prow/jenkins/controller_test.go
Outdated
| }, | ||
| } | ||
| if err := config.SetRegexes(presubmits); err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
t.Fatal, here and elsewhere.
prow/jenkins/controller.go
Outdated
| @@ -306,3 +311,36 @@ func (c *Controller) syncNonPendingJob(pj kube.ProwJob, reports chan<- kube.Prow | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| // TODO: Collapse with plank, impossible to reuse as is due to the interfaces. | |||
| func RunAfterSuccessCanRun(parent, child *kube.ProwJob, c configAgent, ghc githubClient) bool { | |||
There was a problem hiding this comment.
Please document what this does.
spxtr
reviewed
Sep 21, 2017
prow/config/config.go
Outdated
| @@ -227,7 +227,7 @@ func parseConfig(c *Config) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func setRegexes(js []Presubmit) error { | |||
| func SetRegexes(js []Presubmit) error { | |||
There was a problem hiding this comment.
Please add a quick doc string for this.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4504
/assign @spxtr