Fix Kubeadm e2e Tests

[jessicaochen]

No description provided.

[jessicaochen]

/test periodic-kubernetes-e2e-kubeadm-gce-1-7

[jessicaochen]

/test pull-kubernetes-e2e-kubeadm-gce

[jessicaochen]

/ok-to-test

[jessicaochen]

/test pull-kubernetes-bazel-build

[jessicaochen]

/cc @krousey @pipejakob

[jessicaochen]

/assign @krousey @pipejakob

[krzyzacy]

this --tag flag is not going to work for prow jobs..

[jessicaochen]

Will remove

[krzyzacy]

rerun a ci job is trickier, you need to go to places like http://prow.k8s.io/?type=periodic&job=periodic-kubernetes-e2e-kubeadm-gce-1-7 and hit rerun, and go into prow cluster to run the kubectl command.

[pipejakob]

As discussed offline, I believe all of the --tag=latest flags will be inert for our jobs, since we use kubernetes_e2e's LocalMode instead of DockerMode. Aside from that, LGTM as long as it works :-).

[krzyzacy]

--tag=latest only works for docker mode :-) you want to change to e2e-kubeadm:latest in prow/config.json

[krousey]

LGTM from my point of view after the tags are removed.

[krzyzacy]

/lgtm

either bump the image tag, or change that to :latest I guess

[jessicaochen]

@krzyzacy could you merge and bump the kubekins image to pickup the kubetest changes? I can bump the kubeadm image to pickup the changes afterwards (unless you feel like taking care of this as well).

[krzyzacy]

@jessicaochen you can simply cd ./jenkins/e2e-images and make push to get a new kubekins image. (and bump https://github.com/kubernetes/test-infra/blob/master/images/kubeadm/Dockerfile#L15, commit, then push the kubeadm image)

[jessicaochen]

@krzyzacy

Good to know bumping kubekins does not require special steps. I bumped the images. Look good for merge?

[k8s-ci-robot]

@jessicaochen: I updated Prow config for you!

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[krzyzacy]

🤞