-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't build or test vendor in test-infra #5308
don't build or test vendor in test-infra #5308
Conversation
cc @ixdy |
Instead, just delete all |
@spxtr these are bazel tests so you'd have to fix up the BUILD files, I don't think there is any reason to run these. k/k already does this. |
Right, delete the test files and then rerun gazelle. When we switch to |
Sure we could (should?), but I don't see any reason to not also explicitly exclude them in the bazel jobs the same way that we do for k/k, which is somewhat orthogonal. |
I think we can have both. We should not need to build vendor stuff though. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, krzyzacy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/hold cancel |
@BenTheElder: I updated Prow config for you! In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area bazel
/area jobs