786d314 accidentally reverted doc updates?

[schu]

This is a...

• Feature Request
• Bug Report

Problem:

786d314 appears to have reverted an update to content/en/docs/reference/command-line-tools-reference/kube-apiserver.md. The updated warning for the --requestheader-client-ca-file flag from #10093 was changed back to the previous version.

-      <td></td><td style="line-height: 130%; word-wrap: break-word;">Root certificate bundle to use to verify client certificates on incoming requests before trusting usernames in headers specified by --requestheader-username-headers. WARNING: do **not** reuse a CA that is used in a different context (for example with --client-ca-file) unless you understand the risks and the mechanisms to protect the CA's usage. Generally it is recommended to not depend on authorization being already done for incoming requests.</td>
+      <td></td><td style="line-height: 130%; word-wrap: break-word;">Root certificate bundle to use to verify client certificates on incoming requests before trusting usernames in headers specified by --requestheader-username-headers. WARNING: generally do not depend on authorization being already done for incoming requests.</td>

[schu]

cc @jimangel

[jimangel]

@schu those files are automagically generated (see: https://kubernetes.io/docs/contribute/generate-ref-docs/kubernetes-components/). I will need to do some reverse engineering in https://github.com/kubernetes-incubator/reference-docs to see if we can dig up how this misses "--requestheader-client-ca-file"

Is it possible the docs were generated before the command line flag was merged with master? It might be as simple as regenerating the docs.

[schu]

Is it possible the docs were generated before the command line flag was merged with master? It might be as simple as regenerating the docs.

I would guess no since the PR was merged September 6th and 786d314 is from September 28th (but I'm not familiar with the workflow regarding docs).

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[schu]

/remove-lifecycle rotten

[schu]

Something still seems to be off:

https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/ shows the old version from before #10093

https://kubernetes.io/docs/tasks/access-kubernetes-api/configure-aggregation-layer/ and
https://kubernetes.io/docs/reference/access-authn-authz/authentication/ show the updated version as done with #10093

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[schu]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[sftim]

/remove-lifecycle stale
/priority backlog

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[schu]

/remove-lifecycle stale

[schu]

https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/ shows the old version from before #10093

That's still the case.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[kbhawkey]

Hello @schu .
The kube-apiserver docs component page is auto-generated using the
kube-apiserver from the kubernetes/kubernetes repository.
If the text for the flag requestheader-client-ca-file is not correct,
would you open a pull request in kubernetes/kubernetes.
Here is a snippet from v1.18, https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/

<tr>
<td colspan="2">--requestheader-client-ca-file string</td>
</tr>
<tr>
<td></td><td style="line-height: 130%; word-wrap: break-word;">Root certificate bundle to use to verify client certificates on incoming requests before trusting usernames in headers specified by --requestheader-username-headers. WARNING: generally do not depend on authorization being already done for incoming requests.</td>
</tr>

I am closing this issue as the text for the flag description should be changed in kubernetes/kubernetes.

/close

[k8s-ci-robot]

@kbhawkey: Closing this issue.

In response to this:

Hello @schu .
The kube-apiserver docs component page is auto-generated using the
kube-apiserver from the kubernetes/kubernetes repository.
If the text for the flag requestheader-client-ca-file is not correct,
would you open a pull request in kubernetes/kubernetes.
Here is a snippet from v1.18, https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/

<tr>
<td colspan="2">--requestheader-client-ca-file string</td>
</tr>
<tr>
<td></td><td style="line-height: 130%; word-wrap: break-word;">Root certificate bundle to use to verify client certificates on incoming requests before trusting usernames in headers specified by --requestheader-username-headers. WARNING: generally do not depend on authorization being already done for incoming requests.</td>
</tr>

I am closing this issue as the text for the flag description should be changed in kubernetes/kubernetes.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.