Rewrite links for environment-variable-expose-pod-information to new location #10209
Conversation
…location We have a redirect, so these links aren't broken, but we shouldn't rely on the redirect - that ends up with long chains of complicated redirects and makes validating the markdown harder.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 9f85ad1 https://deploy-preview-10209--kubernetes-io-master-staging.netlify.com |
1 similar comment
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 9f85ad1 https://deploy-preview-10209--kubernetes-io-master-staging.netlify.com |
|
👍 |
k8s-ci-robot
added
kind/bug
There was a problem hiding this comment.
/lgtm
I'm inclined to approve this but I'd like to hear opinions about changing the translated contents. We are assuming that defects in the translated contents will be fixed in the translation repo (e.g. kubernetes/kubernetes-docs/zh ) and then committed back to the main repo in batches.
However, for changes like this PR, maybe it is okay to apply it here. The assumptions are as follows:
- the maintainers of the translation site, when committing translated contents back to main repo, will have to do some rebase.
- the rebase won't be a huge pain if the batch commit is performed on a weekly or biweekly basis.
|
/unassign |
|
@tengqm I agree and I think it may be covered with @zacharysarah l10n efforts. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zparnold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kubernetes-docs-i18n-bot
added
the
language/en
We have a redirect, so these links aren't broken, but we shouldn't
rely on the redirect - that ends up with long chains of complicated
redirects and makes validating the markdown harder.