Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Bug fix #10688

Merged
merged 1 commit into from
Oct 24, 2018
Merged

UI Bug fix #10688

merged 1 commit into from
Oct 24, 2018

Conversation

jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented Oct 20, 2018

Remove overflow-x property which takes away the scroll bar, hence making the secondary navbar appear more pretty.
Closes #10685

@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 20, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 20, 2018
@jamesgeorge007
Copy link
Contributor Author

/assign @steveperry-53

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit dab66c7

https://deploy-preview-10688--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 20, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d565f7d

https://deploy-preview-10688--kubernetes-io-master-staging.netlify.com

Copy link

@petetnt petetnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to file this same PR, but the following changes:

  • Use overflow-x: auto instead of removing it alltogether
  • Add -webkit-overflow-scrolling: touch;

This way we get what the original PR needed and get optimized scrolling experience (native-like scroll x without scrollbar) on mobile browsers that support it.

@jamesgeorge007
Copy link
Contributor Author

@petetnt I had made the required changes. Hope it is fine now 👍

@chenopis
Copy link
Contributor

@jamesgeorge007 Awesome! Please resolve the conflicts so I can LGTM.
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenopis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2018
@jamesgeorge007
Copy link
Contributor Author

@chenopis Resolved the conflicts. 👍

@tengqm
Copy link
Contributor

tengqm commented Oct 24, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9cd91a5 into kubernetes:master Oct 24, 2018
@chenopis
Copy link
Contributor

@jamesgeorge007 Strangely, after the conflicts were resolved, the fix didn't work in the preview build. Consequently, even though this is merged, I still see the problem on the website.

screen shot 2018-10-24 at 10 05 06 am

@jamesgeorge007
Copy link
Contributor Author

@chenopis I used node-sass to compile down sass to css which didn't work as intended. I had submitted another PR resolving the issue 👍
Sorry for the trouble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants