-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Bug fix #10688
UI Bug fix #10688
Conversation
/assign @steveperry-53 |
Deploy preview for kubernetes-io-master-staging ready! Built with commit dab66c7 https://deploy-preview-10688--kubernetes-io-master-staging.netlify.com |
Deploy preview for kubernetes-io-master-staging ready! Built with commit d565f7d https://deploy-preview-10688--kubernetes-io-master-staging.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to file this same PR, but the following changes:
- Use
overflow-x: auto
instead of removing it alltogether - Add
-webkit-overflow-scrolling: touch;
This way we get what the original PR needed and get optimized scrolling experience (native-like scroll x without scrollbar) on mobile browsers that support it.
@petetnt I had made the required changes. Hope it is fine now 👍 |
@jamesgeorge007 Awesome! Please resolve the conflicts so I can LGTM. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenopis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chenopis Resolved the conflicts. 👍 |
/lgtm |
@jamesgeorge007 Strangely, after the conflicts were resolved, the fix didn't work in the preview build. Consequently, even though this is merged, I still see the problem on the website. |
@chenopis I used node-sass to compile down sass to css which didn't work as intended. I had submitted another PR resolving the issue 👍 |
Remove
overflow-x
property which takes away the scroll bar, hence making the secondary navbar appear more pretty.Closes #10685