Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix non-existing "CloudProvider Interface" link #10953

Merged
merged 1 commit into from
Nov 28, 2018
Merged

fix non-existing "CloudProvider Interface" link #10953

merged 1 commit into from
Nov 28, 2018

Conversation

iamzhout
Copy link
Contributor

minor change, just get 404 error when clicking the url and try to fix it.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Please delete this note before submitting the pull request.

For 1.13 Features: set Milestone to 1.13 and Base Branch to dev-1.13

Help editing and submitting pull requests:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.

Help choosing which branch to use:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@iamzhout
fix non-existing "CloudProvider Interface" link
ddfda3f 
minor change, just get 404 error when clicking the url and try to fix it.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Nov 11, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ddfda3f

https://deploy-preview-10953--kubernetes-io-master-staging.netlify.com

@iamzhout
Copy link
Contributor Author

/assign @chenopis

@Bradamant3
Copy link
Contributor

@iamzhout Fixing broken links is always good, but your replacement link doesn't point to an interface, and it looks from the readme as though development is moving toward a different model. Maybe you could rewrite the introductory text to refer more generally to cloud provider implementations? Or else dig through the KEPs that are listed in the readme, but that probably won't give us much information about interfaces or coding patterns either.

@Bradamant3
Copy link
Contributor

changing my mind bc this is a complicated situation. The same link exists elsewhere, and it's not clear how to fix or update. Filing an issue to revisit these general cloud provider docs, merging this one for now bc it's better than no fix for a 404.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit 09e07c9 into kubernetes:master Nov 28, 2018
@Bradamant3 Bradamant3 mentioned this pull request Nov 28, 2018
Closed
2 tasks
chenrui333 added a commit that referenced this pull request Dec 3, 2018
@chenrui333
Merge branch 'master' of git://github.com/kubernetes/website into rel…
6e094fa 
…ease-1.12

* 'master' of git://github.com/kubernetes/website: (222 commits)
  Add temporary owners for 1.13 release (#11453)
  fix Minikube 404 error. (#11461)
  Resolve conflicts against dev-1.13 for /ko contents (#11439)
  replace `run` with `create deployment` (#11392)
  Updated list all pods with -o wide comment (#11394)
  fix broken link for KubeletConfiguration (#11423)
  Update on pod-priority-preemption.md (#11418)
  Add guidelines for working with localized content (#11415)
  Update what-is-kubernetes.md (#11399)
  Remove redundant close tags and little bit formatting (#11389)
  Add SysEleven MetaKube as hosted solution (#11393)
  Add rui to sig-docs-zh team (#11391)
  fix Improper translation (#11384)
  Add pigletfly(WangBing) as a sig-docs-zh-reviewer (#11370)
  update link to CloudProvider Interface (#11228)
  Fix the "my-scheduler-as-kube-scheduler" ClusterRoleBinding. (#11112)
  fix non-existing "CloudProvider Interface" link (#10953)
  Updated ingress.md (#11213)
  Further updates to TLS Bootstrapping (#11258)
  Updated 'exec' description (#11365)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

Assignees

@Bradamant3 Bradamant3

@chenopis chenopis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iamzhout @k8sio-netlify-preview-bot @Bradamant3 @k8s-ci-robot @chenopis