Upgrade Hugo to 0.52 #11552
Upgrade Hugo to 0.52 #11552
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/assign @chenopis |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 2d51b3f https://deploy-preview-11552--kubernetes-io-master-staging.netlify.com |
|
@lucperkins Apart from netlify building successfully (which it did) and travis passing (which it did), is there a way we should be testing these changes prior to merge? |
|
@zacharysarah I ran the site locally via both a standard Hugo binary and the Docker image and it worked just fine, as far as I can tell. I think that's about as much of a testing battery as we can throw at it. Perhaps it'd be useful to codify this somewhere? |
|
@lucperkins I didn't test with a docker image, but I also ran locally with success. What are you thinking we should codify outside the issue itself? |
|
Maybe something in the Makefile to verify |
|
@GuessWhoSamFoo Good point--I could foresee potential issues arising if Dockerfile passed in |
k8s-ci-robot
added
size/M
|
@zacharysarah @GuessWhoSamFoo Okay, I think I've found a good solution. I removed the need for a |
|
This approach makes sense to me. |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
| @@ -7,7 +7,7 @@ functions = "functions" | |||
| command = "make non-production-build" | |||
|
|
|||
| [build.environment] | |||
| HUGO_VERSION = "0.52" | |||
| HUGO_VERSION = "0.49" | |||
|
|
|||
| [context.production.environment] | |||
There was a problem hiding this comment.
@lucperkins, can you further explain why the HUGO_VERSION in netlify.toml is remaining at 0.49? Who/what calls the non-production-build target (why should version 0.49 vs 0.52 matter)?
There was a problem hiding this comment.
Good catch. This should indeed also be 0.52. Fixed.
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimangel, lucperkins The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
* Update Hugo version and apply HTML minification to production builds * Use full flag names for clarity * Remove Hugo installation logic out of Travis config and into Makefile * Add Hugo version checking script * Fix Netlify config version
Hugo version 0.52 adds support for HTML minification via the
--minifyflag. This PR updates the "current" Hugo version to 0.52.This change will not impact users running the site locally with an earlier version of Hugo. This will only affect the production build of the site. For users who do upgrade to 0.52 to run the site locally, the in-browser error feature is disabled to ensure a smooth transition. We can discuss enabling that (very nice but potentially disruptive) functionality in the future.