-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update network-policies.md #12181
Update network-policies.md #12181
Conversation
suratwant
commented
Jan 11, 2019
Deploy preview for kubernetes-io-master-staging ready! Built with commit 4537913 https://deploy-preview-12181--kubernetes-io-master-staging.netlify.com |
Looks fine, though I'd expect this to be defaulted by the apiserver anyway - @suratwant were you not seeing this defaulted when attempting to create this policy? |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thank you, no issues faced in practice. Objective was to provide explicit
context for first time readers.
…On Fri, Jan 11, 2019 at 1:42 PM Casey Davenport ***@***.***> wrote:
Looks fine, though I'd expect this to be defaulted by the apiserver anyway
- @suratwant <https://github.com/suratwant> were you not seeing this
defaulted when attempting to create this policy?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12181 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWD975XQsZH-V4K3G34F3DcDR4h3BXWwks5vCQUugaJpZM4Z8IV->
.
|
/assign @steveperry-53
…On Fri, Jan 11, 2019 at 1:49 PM Kubernetes Prow Robot < ***@***.***> wrote:
Thanks for your pull request. Before we can look at your pull request,
you'll need to sign a Contributor License Agreement (CLA).
📝 *Please follow instructions at
https://git.k8s.io/community/CLA.md#the-contributor-license-agreement
<https://git.k8s.io/community/CLA.md#the-contributor-license-agreement> to
sign the CLA.*
It may take a couple minutes for the CLA signature to be fully registered;
after that, please reply here with a new comment and we'll verify. Thanks.
------------------------------
- If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data and verify that your email is set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- If you signed the CLA as a corporation, please sign in with your
organization's credentials at
https://identity.linuxfoundation.org/projects/cncf to be authorized.
- If you have done the above and are still having issues with the CLA
being reported as unsigned, please email the CNCF helpdesk:
***@***.***
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12181 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWD97_okmyCQzAsX_3i9kPht1wANcbXsks5vCQUxgaJpZM4Z8IV->
.
|
/lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tfogo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |