Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpful queries for PR wranglers #12231

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Add helpful queries for PR wranglers #12231

merged 2 commits into from
Jan 17, 2019

Conversation

mdlinville
Copy link
Contributor

/assign @tfogo
/assign @bradtopol

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. language/en Issues or PRs related to English language labels Jan 15, 2019
@mdlinville
Copy link
Contributor Author

/approve cancel

(also asked about ths in Slack #sig-testing channel)

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jan 15, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5223831

https://deploy-preview-12231--kubernetes-io-master-staging.netlify.com

@mdlinville
Copy link
Contributor Author

/assign @jaredbhatti

@mdlinville
Copy link
Contributor Author

Reviewers, you can preview this change at https://deploy-preview-12231--kubernetes-io-master-staging.netlify.com/docs/contribute/advanced/#helpful-github-queries-for-wranglers.

@tengqm
Copy link
Contributor

tengqm commented Jan 16, 2019

lgtm

Fix typo
5223831 
Co-Authored-By: mistyhacks <[email protected]>
@mdlinville
Copy link
Contributor Author

@tengqm Do you mind making the lgtm official?

@tengqm
Copy link
Contributor

tengqm commented Jan 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2019
@mdlinville
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6ca1563 into master Jan 17, 2019
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Jan 29, 2019
@bsalamat
Add helpful queries for PR wranglers (kubernetes#12231)
608fa0a 
* Add helpful queries for PR wranglers

* Fix typo

Co-Authored-By: mistyhacks <[email protected]>
@zacharysarah zacharysarah deleted the mistyhacks/pr-wrangler-queries branch March 28, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbobbytables mrbobbytables mrbobbytables left review comments

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@tfogo tfogo

@tengqm tengqm

@jaredbhatti jaredbhatti

@bradtopol bradtopol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mdlinville @k8sio-netlify-preview-bot @tengqm @k8s-ci-robot @mrbobbytables @tfogo @jaredbhatti @bradtopol