Translate some remnant partials for localization #12239
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit d9a3630 https://deploy-preview-12239--kubernetes-io-master-staging.netlify.com |
| @@ -1,8 +1,9 @@ | |||
| {{ partial "templates/block" (dict "page" .page "block" "overview" "purpose" "states, in one or two sentences, the purpose of this document") }} | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
@tengqm, I guess this line is not needed?
There was a problem hiding this comment.
yes, empty lines means nothing
|
|
||
| [main_feedback_yes] | ||
| other = "Yes" | ||
|
|
There was a problem hiding this comment.
@tengqm, looks good. Is there a reason why the variables are prefixed with main_?
There was a problem hiding this comment.
Was trying to follow an "implicit convention" that most translation entries here have a prefix main_. It can be safely removed.
| For up-to-date documentation, see the <a href="{{ .Site.Params.currentUrl }}">latest</a> version. | ||
| Kubernetes {{ .Param "version" }} | ||
| {{ T "deprecation_warning" }} | ||
| <a href="{{ .Site.Params.currentUrl }}">{{ T "main_latest" }}</a>。 | ||
| </h3> |
There was a problem hiding this comment.
@tengqm, do you need version after latest? I was unable to preview the deprecation warning, as those versions are not re-generated?
There was a problem hiding this comment.
Good suggestion, main_latest_version is indeed a better choice.
There was a problem hiding this comment.
Sure. The original deprecation string ended as ... latest version. instead of just latest.
tengqm
force-pushed
the
translate-partials
branch
from
666b9d0 to
d9a3630
Compare
k8s-ci-robot
removed
the
approved
|
Assigning @chenopis as he is the most appropriate person to review this |
|
@chenopis ping. |
tengqm
force-pushed
the
translate-partials
branch
from
d9a3630 to
f85d484
Compare
| For up-to-date documentation, see the <a href="{{ .Site.Params.currentUrl }}">latest</a> version. | ||
| Kubernetes {{ .Param "version" }} | ||
| {{ T "deprecation_warning" }} | ||
| <a href="{{ .Site.Params.currentUrl }}">{{ T "latest_version" }}</a> |
There was a problem hiding this comment.
I'll let you decide, but you could leave the period outside of the string variables and put it after the </a> link tag.
There was a problem hiding this comment.
Nevermind. I see now that you need to use the Chinese period for the translation.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenopis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
No description provided.