Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Placeholder for ExecutionHook doc #14560

Closed
wants to merge 1 commit into from
Closed

WIP: Placeholder for ExecutionHook doc #14560

wants to merge 1 commit into from

Conversation

xing-yang
Copy link
Contributor

@xing-yang xing-yang commented May 27, 2019 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 27, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 911ae6a

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5cec38dae9f69700088f8746

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tengqm

If they are not already assigned, you can assign the PR to them by writing /assign @tengqm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sftim
sftim reviewed May 27, 2019
View reviewed changes
content/en/docs/concepts/storage/execution-hook.md
---

{{% capture overview %}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xing-yang

Suggested change
{{< feature-state for_k8s_version="v1.15" state="alpha" >}}

Here's a Hugo shortcode that you can use to mark this as an alpha feature (if you want).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Thanks!

@xing-yang xing-yang mentioned this pull request May 27, 2019
Closed
@makoscafee
Copy link
Contributor

/milestone 1.15

@k8s-ci-robot k8s-ci-robot added this to the 1.15 milestone May 29, 2019
@xing-yang
Copy link
Contributor Author

Since all development work for ExecutionHook is out of tree, I was told this doc PR is not needed in-tree. So I'm going to close this PR.

@xing-yang xing-yang closed this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@jimangel jimangel Awaiting requested review from jimangel

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.
5 participants
@xing-yang @k8sio-netlify-preview-bot @k8s-ci-robot @makoscafee @sftim