Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pods user guide to reflect StatefulSet changes #1718

Merged
merged 2 commits into from
Dec 6, 2016
Merged

Update pods user guide to reflect StatefulSet changes #1718

merged 2 commits into from
Dec 6, 2016

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Nov 18, 2016

  1. Adjust Pet and PetSet references, especially under the discussion about "Durability of pods (or lack thereof)".
  2. (TODO) Link to “Tutorial: Running a VM-style workload using StatefulSet”
  3. (TODO) Link to "Task: force deleting a pod."

cc @erictune @foxish @kow3ns @enisoc @kubernetes/sig-apps


This change is Reviewable

@@ -135,9 +135,9 @@ simplified management.

## Durability of pods (or lack thereof)

Pods aren't intended to be treated as durable [pets](https://blog.engineyard.com/2014/pets-vs-cattle). They won't survive scheduling failures, node failures, or other evictions, such as due to lack of resources, or in the case of node maintenance.
Pods aren't intended to be treated as durable [instances](https://blog.engineyard.com/2014/pets-vs-cattle). They won't survive scheduling failures, node failures, or other evictions, such as due to lack of resources, or in the case of node maintenance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blog link was there to explain the "pet" metaphor. Since we're moving away from using that metaphor, does it still make sense to link the blog?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, the blog link is no longer as relevant, and maybe "entities" rather than "instances" due the the latter being an overloaded term?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Removed the link and changed to "entities"

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2016
@erictune
Copy link
Member

LGTM

@devin-donnelly
Copy link
Contributor

This is fine for now; keep in mind that Pod's guide is becoming the Pod concept documentation in the very near future. I'll be sure to track these changes in Pod concept.

@devin-donnelly
Copy link
Contributor

Marking as "Open Issues" for now for the Todo links, once we get the targets merged. Otherwise LGTM.

@janetkuo
Copy link
Member Author

janetkuo commented Dec 2, 2016

Rebased. Todo links depend on #1707 and #1731

@devin-donnelly
Copy link
Contributor

@janetkuo , #1731 has been merged; #1707 is still outstanding and we should resolve that one, then add the links to this one.

@devin-donnelly
Copy link
Contributor

Updated by removing the obsolete TODO links.

@devin-donnelly devin-donnelly merged commit 61c17e6 into kubernetes:release-1.5 Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants