Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace http helm link with https #19803

Merged
merged 1 commit into from
Mar 26, 2020
Merged

replace http helm link with https #19803

merged 1 commit into from
Mar 26, 2020

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Mar 23, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 23, 2020
@oke-py
Copy link
Contributor Author

oke-py commented Mar 23, 2020

/assign @jimangel

@spurin
Copy link
Contributor

spurin commented Mar 23, 2020

Non-member feedback:
/lgtm

@k8s-ci-robot
Copy link
Contributor

@spurin: changing LGTM is restricted to collaborators

In response to this:

Non-member feedback:
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sftim
sftim reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2020
@sftim
Copy link
Contributor

sftim commented Mar 25, 2020

The failed preview looks spurious; this change is fine.

@tengqm
Copy link
Contributor

tengqm commented Mar 26, 2020

/close

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tengqm
Copy link
Contributor

tengqm commented Mar 26, 2020

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

@tengqm: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tengqm
Copy link
Contributor

tengqm commented Mar 26, 2020

/retest

@sftim
Copy link
Contributor

sftim commented Mar 26, 2020

@oke-py can you rebase and force-push? That should trigger a retest.

@oke-py
Copy link
Contributor Author

oke-py commented Mar 26, 2020

I'll do it after I go back home.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2020
@netlify
Copy link

netlify bot commented Mar 26, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d09aa12

https://deploy-preview-19803--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Contributor

tengqm commented Mar 26, 2020

Netlify finally responded ...
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1abc479 into kubernetes:master Mar 26, 2020
@oke-py oke-py deleted the use-https branch March 26, 2020 11:37
@oke-py oke-py mentioned this pull request Mar 27, 2020
Merged
fancc pushed a commit to fancc/website that referenced this pull request Apr 26, 2020
@oke-py @fancc
replace http helm link with https (kubernetes#19803)
1224092
@spurin spurin mentioned this pull request Jul 1, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@chenopis chenopis Awaiting requested review from chenopis

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@jimangel jimangel

@tengqm tengqm

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oke-py @spurin @k8s-ci-robot @sftim @tengqm @jimangel