-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add FR holder for equivalent to PR19774 that was recently merged, tra… #19807
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 026a468 https://deploy-preview-19807--kubernetes-io-master-staging.netlify.com |
@anthonydahanne @abuisine - If either of you can offer a translation of the sentence above it would be appreciated. Thanks |
Hello @spurin
that should do it ^ Thanks for letting us know! |
Thanks @anthonydahanne for the translation, I initially tried to thank you in the commit message, not realising that this wasn't allowed. I've since reverted back to head and have put your translation as a new commit. |
For convenience, link to the changes in the deploy-preview - https://deploy-preview-19807--kubernetes-io-master-staging.netlify.com/fr/docs/concepts/storage/persistent-volumes/#volumes-persistants |
This change looks good to me. |
/assign @abuisine |
Hi @abuisine , could you review, thanks. |
@anthonydahanne do you know how I could request an alternative FR reviewer to close this one out , I think @abuisine may be busy (remarks implied as constructive only). Thanks |
@kubernetes/sig-docs-fr-reviews could you take a look? |
done |
Co-Authored-By: Rémy Léone <[email protected]>
Thanks @remyleone |
@kubernetes/sig-docs-fr-reviews would you mind assigning an alternative assignee please. The reviews and feedback from both @anthonydahanne and @remyleone has been implemented Thanks |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: remyleone The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi All,
I recently made the equivalent change on the English equivalent to this page, it was merged under pull request - #19774
In the spirit of consistency, I can see that there is an equivalent locale version for French. Unfortunately, French is not a language I know and I don't think an online translation service will do this the justice it deserves, so for now, I have put the equivalent holder in place.
Could someone please provide an appropriate translation in the comments and I will update accordingly for further review.
For convenience, the text that needs translation is -
"Helper programs relating to the volume type may be required for consumption of a PersistentVolume within a cluster. In this example, the PersistentVolume is of type NFS and the helper program /sbin/mount.nfs is required to support the mounting of NFS filesystems."
Many Thanks
James