Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FR holder for equivalent to PR19774 that was recently merged, tra… #19807

Merged
merged 2 commits into from
Apr 25, 2020
Merged

Conversation

spurin
Copy link
Contributor

@spurin spurin commented Mar 23, 2020

Hi All,

I recently made the equivalent change on the English equivalent to this page, it was merged under pull request - #19774

In the spirit of consistency, I can see that there is an equivalent locale version for French. Unfortunately, French is not a language I know and I don't think an online translation service will do this the justice it deserves, so for now, I have put the equivalent holder in place.

Could someone please provide an appropriate translation in the comments and I will update accordingly for further review.

For convenience, the text that needs translation is -

"Helper programs relating to the volume type may be required for consumption of a PersistentVolume within a cluster. In this example, the PersistentVolume is of type NFS and the helper program /sbin/mount.nfs is required to support the mounting of NFS filesystems."

Many Thanks

James

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added language/fr Issues or PRs related to French language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 23, 2020
@netlify
Copy link

netlify bot commented Mar 23, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 026a468

https://deploy-preview-19807--kubernetes-io-master-staging.netlify.com

@spurin
Copy link
Contributor Author

spurin commented Mar 23, 2020

@anthonydahanne @abuisine - If either of you can offer a translation of the sentence above it would be appreciated. Thanks

@anthonydahanne
Copy link
Contributor

Hello @spurin

Des logiciel additionnels supportant un type de montage de volume pourraient être nécessaires afin d'utiliser un PersistentVolume depuis un cluster. Dans l'exemple d'un PersistentVolume de type NFS, le logiciel additionnel `/sbin/mount.nfs` est requis pour permettre de monter des systèmes de fichiers de type NFS.

that should do it ^

Thanks for letting us know!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 23, 2020
@spurin spurin closed this Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Mar 23, 2020
@spurin spurin reopened this Mar 23, 2020
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2020
@spurin
Copy link
Contributor Author

spurin commented Mar 23, 2020

Thanks @anthonydahanne for the translation, I initially tried to thank you in the commit message, not realising that this wasn't allowed. I've since reverted back to head and have put your translation as a new commit.

@spurin
Copy link
Contributor Author

spurin commented Mar 23, 2020

@sftim
Copy link
Contributor

sftim commented Mar 26, 2020

This change looks good to me.

@spurin
Copy link
Contributor Author

spurin commented Mar 26, 2020

/assign @abuisine

@spurin
Copy link
Contributor Author

spurin commented Apr 4, 2020

Hi @abuisine , could you review, thanks.

@spurin
Copy link
Contributor Author

spurin commented Apr 15, 2020

@anthonydahanne do you know how I could request an alternative FR reviewer to close this one out , I think @abuisine may be busy (remarks implied as constructive only).

Thanks

@sftim
Copy link
Contributor

sftim commented Apr 15, 2020

@kubernetes/sig-docs-fr-reviews could you take a look?

@remyleone
Copy link
Contributor

done

@spurin
Copy link
Contributor Author

spurin commented Apr 15, 2020

done

Thanks @remyleone

@spurin spurin requested a review from remyleone April 18, 2020 12:54
@spurin
Copy link
Contributor Author

spurin commented Apr 25, 2020

@kubernetes/sig-docs-fr-reviews would you mind assigning an alternative assignee please. The reviews and feedback from both @anthonydahanne and @remyleone has been implemented

Thanks

@remyleone
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: remyleone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3228663 into kubernetes:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Issues or PRs related to French language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants