Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ID holder for equivalent to PR19774 that was recently merged, tra… #19808

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Conversation

spurin
Copy link
Contributor

@spurin spurin commented Mar 23, 2020

Hi All,

I recently made the equivalent change on the English equivalent to this page, it was merged under pull request - #19774

In the spirit of consistency, I can see that there is an equivalent locale version for Indonesia. Unfortunately, Indonesian is not a language I know and I don't think an online translation service will do this the justice it deserves, so for now, I have put the equivalent holder in place.

Could someone please provide an appropriate translation in the comments and I will update accordingly for further review.

For convenience, the text that needs translation is -

"Helper programs relating to the volume type may be required for consumption of a PersistentVolume within a cluster. In this example, the PersistentVolume is of type NFS and the helper program /sbin/mount.nfs is required to support the mounting of NFS filesystems."

Many Thanks

James

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language labels Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 23, 2020
@netlify
Copy link

netlify bot commented Mar 23, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8e894f8

https://deploy-preview-19808--kubernetes-io-master-staging.netlify.com

@spurin
Copy link
Contributor Author

spurin commented Mar 23, 2020

@girikuncoro @irvifa - If either of you can offer a translation of the sentence above it would be appreciated. Thanks

@spurin spurin changed the title add ID holder for equivalent to PR19774 that was recently merged, tra… WIP add ID holder for equivalent to PR19774 that was recently merged, tra… Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2020
@girikuncoro
Copy link
Contributor

sure @spurin thanks for doing this! here's the translation:

"Helper programs relating to the volume type may be required for consumption of a PersistentVolume within a cluster. In this example, the PersistentVolume is of type NFS and the helper program /sbin/mount.nfs is required to support the mounting of NFS filesystems."

Program pembantu yang berkaitan dengan tipe volume bisa saja diperlukan untuk mengonsumsi sebuah PersistentVolume di dalam klaster. Contoh ini menggunakan PersistentVolume dengan tipe NFS dan program pembantu /sbin/mount.nfs diperlukan untuk mendukung proses mounting sistem berkas (filesystem) NFS.

@spurin spurin changed the title WIP add ID holder for equivalent to PR19774 that was recently merged, tra… add ID holder for equivalent to PR19774 that was recently merged, tra… Mar 24, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2020
@spurin
Copy link
Contributor Author

spurin commented Mar 24, 2020

Thanks @girikuncoro for your translation, appreciated. I have updated the note accordingly.

@spurin
Copy link
Contributor Author

spurin commented Mar 24, 2020

@girikuncoro
Copy link
Contributor

looking good, thank you so much for your contribution @spurin! 🎉

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@sftim
Copy link
Contributor

sftim commented Mar 24, 2020

/hold
pending v1.18 Kubernetes release

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
@VineethReddy02
Copy link
Contributor

/hold cancel
v1.18 release is out.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5b4c9e0 into kubernetes:master Mar 26, 2020
fancc pushed a commit to fancc/website that referenced this pull request Apr 26, 2020
kubernetes#19808)

* add ID holder for equivalent to PR19774 that was recently merged, translation help needed

* add Indonesian translation for /sbin/mount.nfs note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants