Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content/pt/docs/concepts/scheduling/kube-scheduler.md #20460

Merged
merged 14 commits into from
May 6, 2020
Merged

Add content/pt/docs/concepts/scheduling/kube-scheduler.md #20460

merged 14 commits into from
May 6, 2020

Conversation

viniciusbds
Copy link
Contributor

This PR translate the kube-scheduler topic

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 20, 2020
@k8s-ci-robot k8s-ci-robot added language/pt Issues or PRs related to Portuguese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 20, 2020
@netlify
Copy link

netlify bot commented Apr 20, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit dea0dec

https://deploy-preview-20460--kubernetes-io-master-staging.netlify.app

@viniciusbds
Copy link
Contributor Author

/assign @jhonmike
/assign @femrtnz

jhonmike
jhonmike reviewed Apr 21, 2020
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading quickly I found small adjustments

sftim
sftim reviewed Apr 28, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, if you wish to accept them. Please do not treat this feedback as a demand to change the content before merging.

(I don't speak Portuguese at all well).

@devlware
Copy link
Contributor

I'll take a look later today.

@devlware
Copy link
Contributor

@viniciusbds Can you check the look and feel of the doc. When resizing the window the lines are not aligning properly. I believe that you miss inserted some code.

@viniciusbds
Copy link
Contributor Author

Hi @devlware. Here in my browser it seems to work as expected. Could you send an image / gif that shows this error?

devlware
devlware requested changes May 2, 2020
View reviewed changes
Copy link
Contributor

@devlware devlware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viniciusbds the look and feel problem was on my side. Sorry for that.
I reviewed your translation and left some requests for changes. There is one nit pick. Otherwise, it looks good to me.
After fixing this I think we can go ahead and merge your request.

Thanks for helping the project.

@devlware
Copy link
Contributor

devlware commented May 6, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devlware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7bf9754 into kubernetes:master May 6, 2020
@viniciusbds viniciusbds deleted the translate-scheduling-topic-ptbr branch May 18, 2020 16:19
@viniciusbds viniciusbds mentioned this pull request May 23, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhonmike jhonmike jhonmike left review comments

@femrtnz femrtnz femrtnz left review comments

@sftim sftim sftim left review comments

@devlware devlware devlware requested changes

Assignees

@devlware devlware

@jhonmike jhonmike

@femrtnz femrtnz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/pt Issues or PRs related to Portuguese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@viniciusbds @devlware @k8s-ci-robot @jhonmike @femrtnz @sftim