Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark StreamingProxyRedirects deprecated in 1.19 #21703

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Mark StreamingProxyRedirects deprecated in 1.19 #21703

merged 1 commit into from
Jul 6, 2020

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jun 13, 2020

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 58c152a

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5ee4732235d7cd0008c6dcfa

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 13, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 13, 2020
@tengqm
Copy link
Contributor Author

tengqm commented Jun 13, 2020

/milestone 1.19

@k8s-ci-robot k8s-ci-robot added this to the 1.19 milestone Jun 13, 2020
@tengqm
Copy link
Contributor Author

tengqm commented Jun 20, 2020

/assign @savitharaghunathan

@jimangel
Copy link
Member

jimangel commented Jul 6, 2020 •
edited
Loading

/lgtm
/unassign

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2020
savitharaghunathan
savitharaghunathan reviewed Jul 6, 2020
View reviewed changes
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitharaghunathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7825b79 into kubernetes:dev-1.19 Jul 6, 2020
@tengqm tengqm deleted the StreamingProxyRedirects branch July 20, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitharaghunathan savitharaghunathan savitharaghunathan left review comments

@daminisatya daminisatya Awaiting requested review from daminisatya

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@jimangel jimangel

@savitharaghunathan savitharaghunathan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@tengqm @k8sio-netlify-preview-bot @jimangel @k8s-ci-robot @savitharaghunathan