Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update storage-classes pv section link #22109

Merged
merged 1 commit into from
Jun 28, 2020
Merged

update storage-classes pv section link #22109

merged 1 commit into from
Jun 28, 2020

Conversation

spurin
Copy link
Contributor

@spurin spurin commented Jun 27, 2020

Hi,

Hope you're all well today. A nice and quick contribution, an Indonesian equivalent for a recent PR that was recently closed, #22108

This relates to issue #22107

In the original issue and fix, there are two files affected. In the IN docs, I only found one and have fixed in the same way.

For convenience, updated page - https://deploy-preview-22109--kubernetes-io-master-staging.netlify.app/id/docs/concepts/storage/storage-classes/

And the updated link - https://deploy-preview-22109--kubernetes-io-master-staging.netlify.app/id/docs/concepts/storage/persistent-volumes/#persistentvolumeclaims

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2020
@k8s-ci-robot k8s-ci-robot requested review from phanama and wahyuoi June 27, 2020 18:31
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 27, 2020
@netlify
Copy link

netlify bot commented Jun 27, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4d4a6b5

https://deploy-preview-22109--kubernetes-io-master-staging.netlify.app

@spurin
Copy link
Contributor Author

spurin commented Jun 27, 2020

/assign @irvifa

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2020
@irvifa
Copy link
Member

irvifa commented Jun 28, 2020

/approve.

Thanks all!

@irvifa
Copy link
Member

irvifa commented Jun 28, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit c53077e into kubernetes:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants