Updated ingress.md TLS section #23522
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/XS
|
/assign @SFTI |
|
/sig network |
k8s-ci-robot
added
the
sig/network
|
I wonder if another approach is better: create a new Task page that describes how to set up TLS for your workload, and describe this detail there rather than in the Ingress concept. |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 73780ca https://deploy-preview-23522--kubernetes-io-master-staging.netlify.app |
|
@VladMasarik if I start work on that Task page, would you be willing to help with the Ingress TLS documentation? |
|
@sftim Ahhh, you mean creating new section in ( https://kubernetes.io/docs/tasks/tls/ ) and there describing how to set it up? Could be a good idea! Sure I would help, although not sure how long it will be relevant. I was following instructions from cert-manager / helm pages from a year ago, and even those were rather outdated. Still I would be up for it, just tag me in a PR / Issue. |
|
@sftim ping |
|
This is on my list of things to help with - I'm not sure when I'd get time @VladMasarik |
|
Sure no problem, and what about this PR? Should we close it, let it get stale and closed automatically, or merge and later when we get to writing the guide remove this text? |
|
@sftim because after some time, it will turn into a dead PR, although there is a solution. Like this one. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7b645e954f0f850749effc26a37669e6f498a442
|
k8s-ci-robot
added
needs-rebase
|
@sftim Added the notes as suggested |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zparnold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks @VladMasarik . |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: eafb3daf8afbd91f17c8b40666a228782eb1d5e0
|
I missed the fact that for TLS to work, Ingress resource has to explicitly mention
hostfromrulespart. I thought that the default routing rule ( the one withouthostfield ) would work as well. Only recently I realized that the certificates would have to contain all the possible sub-domains to work for default rule. Well, I wish to stop other "not so smart" people from missing that as well. It possibly is mentioned somewhere, but me, nor my colleagues, found it.