Add warning about using unsupported CRON_TZ #30509

soltysh · 2021-11-16T16:03:13Z

This is fixing a mistake that was introduced during bumping an internal library.
More information and pointers to sig-apps discussion from yesterday are in
https://groups.google.com/g/kubernetes-sig-apps/c/-hohVua2JO4/m/31SJODnWAgAJ

/assign @atiratree

netlify · 2021-11-16T16:03:19Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 9a441b0

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6193d6433b458c00074fd618

sftim · 2021-11-16T16:06:59Z

/sig apps

This definitely needs technical review from the relevant SIG.

sftim

We should remove or reword the example:

`CRON_TZ=UTC 0 0 13 * 5`

(see the heading Cron schedule syntax)

content/en/docs/concepts/workloads/controllers/cron-jobs.md

sftim · 2021-11-16T16:18:13Z

If we document for v1.23 that it's not supported, we should also update the docs for v1.22 in some way.

Alternatively, we apply this change to the main branch (currently v1.22)

soltysh · 2021-11-16T16:23:56Z

If we document for v1.23 that it's not supported, we should also update the docs for v1.22 in some way.

Correct, it's for both 1.22 and 1.23

soltysh · 2021-11-16T16:29:42Z

Alternatively, we apply this change to the main branch (currently v1.22)

Yup, did that after recommendation from @reylejano

netlify · 2021-11-16T16:32:40Z

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 0770500

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6193d9c7c8e279000769e544

😎 Browse the preview: https://deploy-preview-30509--kubernetes-io-main-staging.netlify.app

content/en/docs/concepts/workloads/controllers/cron-jobs.md

sftim · 2021-11-16T16:34:57Z

content/en/docs/concepts/workloads/controllers/cron-jobs.md

+The [v1 CronJob API](/docs/reference/kubernetes-api/workload-resources/cron-job-v1/)
+does not officially support setting timezone as explained above.
+
+Setting variables such as `CRON_TZ` or `TZ is not officially supported by the Kubernetes project.


Markdown nit

Suggested change

Setting variables such as `CRON_TZ` or `TZ is not officially supported by the Kubernetes project.

Setting variables such as `CRON_TZ` or `TZ` is not officially supported by the Kubernetes project.

sftim · 2021-11-16T16:35:45Z

In effect, this reverts PR #29455

netlify · 2021-11-16T16:38:05Z

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: b5e83e8

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6193de7236a01d00087c768b

😎 Browse the preview: https://deploy-preview-30509--kubernetes-io-main-staging.netlify.app

soltysh · 2021-11-16T16:39:26Z

In effect, this reverts PR #29455

Correct.

BenTheElder · 2021-11-16T18:29:11Z

content/en/docs/concepts/workloads/controllers/cron-jobs.md

@@ -28,6 +26,16 @@ containers, the timezone set for the kube-controller-manager container determine
 that the cron job controller uses.
 {{< /caution >}}

+{{< caution >}}
+The [v1 CronJob API](/docs/reference/kubernetes-api/workload-resources/cron-job-v1/)
+does not officially support setting timezone as explained above.


"as explained above" ?
edit: maybe I'm misreading this, but it seems like we removed the explanation of setting this?
edit2: and actually explain below 🤔

I think this is OK to merge with the existing wording but a follow-up to clarify would be welcome.

above is a caution about cronjob using timezone from kube-controller-manager's host, that's what I've meant with it

Feedback was incorporated

sftim · 2021-11-16T23:58:48Z

If we want a short URL like https://k8s.io/cron-tz-environment then that's also available (log a feature request and we can get onto it).

soltysh · 2021-11-17T11:34:44Z

@sftim I think we'll be fine with the current link https://kubernetes.io/docs/concepts/workloads/controllers/cron-jobs/ I'll reach out to you on slack about publishing a blog post describing this entire situation.

soltysh · 2021-11-17T11:48:02Z

If there is no further feedback, I'd appreciate getting this one merged, I have 1.22 (kubernetes/kubernetes#106487) in the queue already

sftim · 2021-11-17T11:51:46Z

On behalf of SIG Docs, I'd like SIG ~~Node~~ Apps to provide a tech review here. @soltysh I'm afraid that as the author you can't review your own work.

atiratree · 2021-11-17T13:12:00Z

/lgtm

k8s-ci-robot · 2021-11-17T13:12:25Z

LGTM label has been added.

Git tree hash: 7dfe95f612cf88fa30e87108f510fcffba0b30fa

sftim · 2021-11-17T15:15:17Z

Thanks @atiratree - I'm assuming your LGTM was to be counted as a tech review for SIG Apps?

/approve

k8s-ci-robot · 2021-11-17T15:15:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

atiratree · 2021-11-17T15:34:44Z

@sftim yes, thanks for the approve

k8s-ci-robot assigned atiratree Nov 16, 2021

k8s-ci-robot added this to the 1.23 milestone Nov 16, 2021

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 16, 2021

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Nov 16, 2021

k8s-ci-robot requested review from onlydole and sftim November 16, 2021 16:03

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 16, 2021

k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Nov 16, 2021

sftim previously requested changes Nov 16, 2021

View reviewed changes

content/en/docs/concepts/workloads/controllers/cron-jobs.md Outdated Show resolved Hide resolved

content/en/docs/concepts/workloads/controllers/cron-jobs.md Outdated Show resolved Hide resolved

soltysh changed the base branch from dev-1.23 to main November 16, 2021 16:17

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2021

soltysh force-pushed the cronjob_warning branch from 9a441b0 to 0770500 Compare November 16, 2021 16:18

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2021

soltysh force-pushed the cronjob_warning branch from 0770500 to 59f7faa Compare November 16, 2021 16:23

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2021

soltysh force-pushed the cronjob_warning branch from 59f7faa to a2f0843 Compare November 16, 2021 16:25

soltysh mentioned this pull request Nov 16, 2021

Add warning about using unsupported CRON_TZ kubernetes/kubernetes#106455

Merged

cndoit18 reviewed Nov 16, 2021

View reviewed changes

content/en/docs/concepts/workloads/controllers/cron-jobs.md Show resolved Hide resolved

sftim reviewed Nov 16, 2021

View reviewed changes

Add warning about using unsupported CRON_TZ

b5e83e8

soltysh force-pushed the cronjob_warning branch from a2f0843 to b5e83e8 Compare November 16, 2021 16:38

BenTheElder reviewed Nov 16, 2021

View reviewed changes

sftim mentioned this pull request Nov 16, 2021

CRON_TZ documented for CronJob but actually not supported #30511

Closed

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021

k8s-ci-robot merged commit 0aa00b6 into kubernetes:main Nov 17, 2021

benlangfeld mentioned this pull request Nov 17, 2021

CronJobs should support timezones kubernetes/kubernetes#47202

Closed

cndoit18 mentioned this pull request Nov 18, 2021

[zh]: Add warning about using unsupported CRON_TZ #30542

Merged

soltysh deleted the cronjob_warning branch July 26, 2022 11:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add warning about using unsupported CRON_TZ #30509

Add warning about using unsupported CRON_TZ #30509

soltysh commented Nov 16, 2021

netlify bot commented Nov 16, 2021

sftim commented Nov 16, 2021

sftim left a comment

sftim commented Nov 16, 2021

soltysh commented Nov 16, 2021

soltysh commented Nov 16, 2021

netlify bot commented Nov 16, 2021

sftim Nov 16, 2021

soltysh Nov 16, 2021

sftim commented Nov 16, 2021

netlify bot commented Nov 16, 2021 •

edited

Loading

soltysh commented Nov 16, 2021

BenTheElder Nov 16, 2021 •

edited

Loading

sftim Nov 16, 2021

soltysh Nov 16, 2021

sftim commented Nov 16, 2021

soltysh commented Nov 17, 2021

soltysh commented Nov 17, 2021

sftim commented Nov 17, 2021 •

edited

Loading

atiratree commented Nov 17, 2021

k8s-ci-robot commented Nov 17, 2021

sftim commented Nov 17, 2021

k8s-ci-robot commented Nov 17, 2021

atiratree commented Nov 17, 2021

	Setting variables such as `CRON_TZ` or `TZ is not officially supported by the Kubernetes project.
	Setting variables such as `CRON_TZ` or `TZ` is not officially supported by the Kubernetes project.

Add warning about using unsupported CRON_TZ #30509

Add warning about using unsupported CRON_TZ #30509

Conversation

soltysh commented Nov 16, 2021

netlify bot commented Nov 16, 2021

sftim commented Nov 16, 2021

sftim left a comment

Choose a reason for hiding this comment

sftim commented Nov 16, 2021

soltysh commented Nov 16, 2021

soltysh commented Nov 16, 2021

netlify bot commented Nov 16, 2021

sftim Nov 16, 2021

Choose a reason for hiding this comment

soltysh Nov 16, 2021

Choose a reason for hiding this comment

sftim commented Nov 16, 2021

netlify bot commented Nov 16, 2021 • edited Loading

soltysh commented Nov 16, 2021

BenTheElder Nov 16, 2021 • edited Loading

Choose a reason for hiding this comment

sftim Nov 16, 2021

Choose a reason for hiding this comment

soltysh Nov 16, 2021

Choose a reason for hiding this comment

sftim commented Nov 16, 2021

soltysh commented Nov 17, 2021

soltysh commented Nov 17, 2021

sftim commented Nov 17, 2021 • edited Loading

atiratree commented Nov 17, 2021

k8s-ci-robot commented Nov 17, 2021

sftim commented Nov 17, 2021

k8s-ci-robot commented Nov 17, 2021

atiratree commented Nov 17, 2021

netlify bot commented Nov 16, 2021 •

edited

Loading

BenTheElder Nov 16, 2021 •

edited

Loading

sftim commented Nov 17, 2021 •

edited

Loading