Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the etcd client certs #30562

Closed
wants to merge 1 commit into from
Closed

Conversation

h4ghhh
Copy link
Contributor

@h4ghhh h4ghhh commented Nov 19, 2021

Using ‘server’ key is easily misunderstood.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2021
@k8s-ci-robot k8s-ci-robot requested review from mml and wojtek-t November 19, 2021 10:55
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 19, 2021
@netlify
Copy link

netlify bot commented Nov 19, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 1930948

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61a46ae7c4d0d30007167be0

😎 Browse the preview: https://deploy-preview-30562--kubernetes-io-main-staging.netlify.app

@jihoon-seo
Copy link
Member

Hello @h4ghhh
I recommend you to include only the English version changes in this PR,
and the Chinese version changes in another PR. 😊


https://kubernetes.io/docs/contribute/new-content/#languages-per-pr

Languages per PR

Limit pull requests to one language per PR. If you need to make an identical change to the same code sample in multiple languages, open a separate PR for each language.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign celestehorgan after the PR has been reviewed.
You can assign the PR to them by writing /assign @celestehorgan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@h4ghhh
Copy link
Contributor Author

h4ghhh commented Nov 29, 2021

Hello @h4ghhh I recommend you to include only the English version changes in this PR, and the Chinese version changes in another PR. blush

https://kubernetes.io/docs/contribute/new-content/#languages-per-pr

Languages per PR

Limit pull requests to one language per PR. If you need to make an identical change to the same code sample in multiple languages, open a separate PR for each language.

@jihoon-seo
Ok.
Another pr for Chinese is #30665. Could you review them for me?
Thanks.

@jihoon-seo
Copy link
Member

Hmm, I wish someone else do a technical review on this PR 😊.
/remove-language zh

@k8s-ci-robot k8s-ci-robot removed the language/zh Issues or PRs related to Chinese language label Nov 30, 2021
@jimangel
Copy link
Member

jimangel commented Dec 6, 2021

@h4ghhh in many cases those certificates are automatically generated and are named server.*. I don't believe this change is technically accurate, but feel free to reopen with more supporting evidence! Thanks!

/close

@k8s-ci-robot
Copy link
Contributor

@jimangel: Closed this PR.

In response to this:

@h4ghhh in many cases those certificates are automatically generated and are named server.*. I don't believe this change is technically accurate, but feel free to reopen with more supporting evidence! Thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@h4ghhh
Copy link
Contributor Author

h4ghhh commented Dec 6, 2021

@h4ghhh in many cases those certificates are automatically generated and are named server.*. I don't believe this change is technically accurate, but feel free to reopen with more supporting evidence! Thanks!

/close

Ok, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants