Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure-gmsa.md updates #31412

Merged
merged 3 commits into from
Jan 20, 2022
Merged

configure-gmsa.md updates #31412

merged 3 commits into from
Jan 20, 2022

Conversation

marosset
Copy link
Contributor

Updating the container runtimes that support GMSA workloads on Windows.

All of the current container runtimes (Docker EE / Mirantis Container Runtime (via cri-dockerd) and containerd) have this support today.

/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2022
@marosset
Copy link
Contributor Author

/cc @celestehorgan
/assign @jsturtevant

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 19, 2022
@k8s-ci-robot k8s-ci-robot requested a review from tengqm January 19, 2022 23:05
@netlify
Copy link

netlify bot commented Jan 19, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 6ffd07c

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61e8a911324e6200071c0744

😎 Browse the preview: https://deploy-preview-31412--kubernetes-io-main-staging.netlify.app

jsturtevant
jsturtevant reviewed Jan 19, 2022
View reviewed changes
content/en/docs/tasks/configure-pod-container/configure-gmsa.md Outdated

There is also a known issue with containerd that occurs when trying to connect to SMB shares from Pods. Once you have configured GMSA, the pod will be unable to connect to the share using the hostname or FQDN, but connecting to the share using an IP address works as expected.
There is also a known issue with containerd that occurs when trying to connect to SMB shares from Pods. Once you have configured GMSA, the pod will be unable to connect to the share using the hostname or FQDN, but connecting to the share using an IP address works as expected.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was resolved in the March 2021 patch fix microsoft/Windows-Containers#44 (comment) so can be dropped from docs as that is the recommended min version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
I made some updates for this (and hopefully they make sense).

celestehorgan
celestehorgan approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@celestehorgan celestehorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref for other reviewers: https://kubernetes.slack.com/archives/C0BP8PW9G/p1642628900084800

Partially closes #30771

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celestehorgan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 537439fbafb72a34cd3425a444cbad38069436a1

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit f59a649 into kubernetes:main Jan 20, 2022
@marosset marosset mentioned this pull request Jan 20, 2022
Open
31 tasks
@marosset marosset deleted the gmsa-container-runtime branch January 20, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@celestehorgan celestehorgan celestehorgan approved these changes

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@jsturtevant jsturtevant

@celestehorgan celestehorgan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marosset @k8s-ci-robot @jsturtevant @celestehorgan