feat: feature gate DefaultPodTopologySpread is GA #32003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy Preview for kubernetes-io-vnext-staging processing. 🔨 Explore the source changes: c5428eb 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6220ebbb04a70e000731c92f |
k8s-ci-robot
added
cncf-cla: yes
|
/sig scheduling |
k8s-ci-robot
added
language/en
sftim
reviewed
Mar 2, 2022
There was a problem hiding this comment.
Should we also revise this text:
The score produced by default scheduling constraints might conflict with the
score produced by the
[`SelectorSpread` plugin](/docs/reference/scheduling/config/#scheduling-plugins).
It is recommended that you disable this plugin in the scheduling profile when
using default constraints for `PodTopologySpread`.eg to highlight that SelectorSpread is disabled by default, so the advice is really “don't enable this”
content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md
Outdated
Show resolved
Hide resolved
kerthcet
force-pushed
the
feature/graduate-defaultPodTopologySpread-to-ga
branch
from
89a2718 to
f6f8fd1
Compare
k8s-ci-robot
added
size/M
kbhawkey
reviewed
Mar 3, 2022
content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md
Outdated
Show resolved
Hide resolved
kerthcet
force-pushed
the
feature/graduate-defaultPodTopologySpread-to-ga
branch
from
f6f8fd1 to
480adc9
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 854a8a88b7854b0fa17a5513da6088748e9310be
|
sftim
reviewed
Mar 3, 2022
content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md
Outdated
Show resolved
Hide resolved
Signed-off-by: kerthcet <[email protected]>
kerthcet
force-pushed
the
feature/graduate-defaultPodTopologySpread-to-ga
branch
from
480adc9 to
c5428eb
Compare
k8s-ci-robot
removed
the
lgtm
|
Still |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a1462fb4f64fe3a2e199d2ec5a77cced714a4773
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbhawkey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kerthcet [email protected]
Part of kubernetes/enhancements#1258