Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node-eviction-rate zh translation #33583

Merged
merged 1 commit into from
May 10, 2022

Conversation

jlsong01
Copy link
Contributor

fix #33540

For kube-controller-manager node-eviction-rate, the Chinese document of "when a zone is healthy" is completely the opposite meaning.

This is PR is trying to fix it .

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/zh Issues or PRs related to Chinese language labels May 10, 2022
@k8s-ci-robot k8s-ci-robot requested review from idealhack and SataQiu May 10, 2022 01:13
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 10, 2022
@netlify
Copy link

netlify bot commented May 10, 2022

Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit f8853cc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6279bc17e918360008e92c3a
😎 Deploy Preview https://deploy-preview-33583--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@xichengliudui
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xichengliudui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0bcaae9d7f1307a6e836b3f2e4a817f8683f2085

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit d72ae99 into kubernetes:main May 10, 2022
@tengqm
Copy link
Contributor

tengqm commented May 10, 2022

This is terrible mistake. The file modified is out of sync. Even we revert this change, we are losing track of the upstream change because the localized version is newer than the English upstream version anyway.

For people who will resync the file, please make sure you are checking out the 5bfab64 commit.

@tengqm
Copy link
Contributor

tengqm commented May 10, 2022

Updated #33478 task 9 to remind people when doing the next round of resync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-controller-manager node-eviction-rate translation
4 participants