Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] Update volumes.md #33800

Closed
wants to merge 1 commit into from
Closed

[zh] Update volumes.md #33800

wants to merge 1 commit into from

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented May 18, 2022

[zh] Update volumes.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sataqiu after the PR has been reviewed.
You can assign the PR to them by writing /assign @sataqiu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from chenxuc and idealhack May 18, 2022 14:07
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 18, 2022
Sea-n
Sea-n reviewed May 18, 2022
View reviewed changes
content/zh/docs/concepts/storage/volumes.md Outdated
Comment on lines 1604 to 1606
### vsphereVolume {#vspherevolume}
### vsphereVolume (deprecated) {#vspherevolume}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be translated to ### vsphereVolume （已棄用） {#vspherevolume}.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @my-git9, your fix-up commit seems to put the English comment in the wrong place. 😅

BTW, are you in the Kubernetes Slack? We can inform you about small things like this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@netlify
Copy link

netlify bot commented May 18, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 83d8a38
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62850a4418304e00083e7233
😎 Deploy Preview https://deploy-preview-33800--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented May 19, 2022

@my-git9 Please coordinate with @mengjiao-liu since this page is captured in #33476 as part of 'concepts-3'.

@my-git9 my-git9 closed this May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sea-n Sea-n Sea-n left review comments

@chenxuc chenxuc Awaiting requested review from chenxuc

@idealhack idealhack Awaiting requested review from idealhack

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@my-git9 @k8s-ci-robot @tengqm @Sea-n