Cinder conditionally supports ReadWriteMany volumes #34219

jdmaguire · 2022-06-10T14:22:57Z

While looking through some K8s and OpenStack issues/documentation, I noticed that the Persistent Volumes page incorrectly lists Cinder as not supporting ReadWriteMany volumes. By default, this is correct; however, since OpenStack Queens, there is some support for ReadWriteMany K8s volumes.

This is how the table looks like now:

linux-foundation-easycla · 2022-06-10T14:23:01Z

The committers listed above are authorized under a signed CLA.

✅ login: jdmaguire / name: John Daniel Maguire (fc2e67d)

k8s-ci-robot · 2022-06-10T14:23:05Z

Welcome @jdmaguire!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

netlify · 2022-06-10T14:35:52Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`9a00320`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62cc1459faf1ab00086651d5
😎 Deploy Preview	https://deploy-preview-34219--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim · 2022-06-12T16:24:57Z

/sig storage

xing-yang · 2022-07-07T18:27:11Z

content/en/docs/concepts/storage/persistent-volumes.md

@@ -558,7 +558,7 @@ If the access modes are specified as ReadWriteOncePod, the volume is constrained
 | AzureFile            | &#x2713;               | &#x2713;              | &#x2713;      | -                      |
 | AzureDisk            | &#x2713;               | -                     | -             | -                      |
 | CephFS               | &#x2713;               | &#x2713;              | &#x2713;      | -                      |
-| Cinder               | &#x2713;               | -                     | -             | -                      |
+| Cinder               | &#x2713;               | -                     | ([if multi-attach volumes are available](https://github.com/kubernetes/cloud-provider-openstack/issues/1315))            | -                      |


On this issue kubernetes/cloud-provider-openstack#1315, there is the following link to the multi-attach doc, but it is on someone's private repo? Is it somewhere in a merged official doc? Also in the multi-attach doc, it uses CSC tools from gocsi which is no longer supported. Do you have plan to use a different tool?

https://github.com/ramineni/cloud-provider-openstack/blob/953450377f722274295c7a27536c9afa772f1bc7/docs/using-cinder-csi-plugin.md#multi-attach-volumes

The official docs do mention multi-attached cinder volumes.

https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/cinder-csi-plugin/features.md#multi-attach-volumes

The official documentation is lacking on how one creates these. https://docs.openstack.org/cinder/latest/admin/volume-multiattach.html does go into more details with the cinder cli.

I hadn't noticed that the link in that GH issue was on a fork of the docs. I'll switch to the official docs.

Thanks Xing.

Signed-off-by: John Daniel Maguire <[email protected]>

xing-yang · 2022-07-12T17:39:14Z

/lgtm

k8s-ci-robot · 2022-07-12T17:39:32Z

LGTM label has been added.

Git tree hash: c5a3becb28a073ead5b61cc6ae7416fb3a0210ec

kbhawkey · 2022-07-16T14:23:37Z

Preview:
https://deploy-preview-34219--kubernetes-io-main-staging.netlify.app/docs/concepts/storage/persistent-volumes/#access-modes

/label tide/merge-method-squash

kbhawkey · 2022-07-16T14:24:44Z

Thanks @jdmaguire and @xing-yang
/approve

k8s-ci-robot · 2022-07-16T14:25:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [kbhawkey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Cinder conditionally supports ReadWriteMany volumes * Link directly to official docs. Signed-off-by: John Daniel Maguire <[email protected]>

Storage classes using the provisioner 'cinder.csi.openstack.org' appear in kubernetes clusters that have been created on OpenStack infrastructure. Although some cinder volume types can support multi-attach (ReadWriteMany), we cannot be certain of this. Therefore, we suggest a claimPropertSet of RWO,Block. See kubernetes/website#34219 for more context. Signed-off-by: Adam Litke <[email protected]>

Storage classes using the provisioner 'cinder.csi.openstack.org' appear in kubernetes clusters that have been created on OpenStack infrastructure. Although some cinder volume types can support multi-attach (ReadWriteMany), we cannot be certain of this. Therefore, we suggest a claimPropertSet of RWO,Block. See kubernetes/website#34219 for more context. Signed-off-by: Adam Litke <[email protected]> Signed-off-by: Adam Litke <[email protected]>

… (#2507) (#2532) * Add cinder to known provisioners (#2507) Storage classes using the provisioner 'cinder.csi.openstack.org' appear in kubernetes clusters that have been created on OpenStack infrastructure. Although some cinder volume types can support multi-attach (ReadWriteMany), we cannot be certain of this. Therefore, we suggest a claimPropertSet of RWO,Block. See kubernetes/website#34219 for more context. Signed-off-by: Adam Litke <[email protected]> Signed-off-by: Adam Litke <[email protected]> * Add topolvm.io to known provisioners (#2530) Fix bug 2158521 Signed-off-by: Jenia Peimer <[email protected]> Signed-off-by: Jenia Peimer <[email protected]> Signed-off-by: Adam Litke <[email protected]> Signed-off-by: Jenia Peimer <[email protected]> Co-authored-by: Adam Litke <[email protected]>

Cinder conditionally supports ReadWriteMany volumes

fc2e67d

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 10, 2022

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jun 10, 2022

k8s-ci-robot requested review from thockin and xing-yang June 10, 2022 14:23

k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 10, 2022

k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jun 12, 2022

xing-yang reviewed Jul 7, 2022

View reviewed changes

Link directly to official docs.

9a00320

Signed-off-by: John Daniel Maguire <[email protected]>

k8s-ci-robot assigned xing-yang Jul 12, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2022

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 16, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2022

k8s-ci-robot merged commit 13a3118 into kubernetes:main Jul 16, 2022

jdmaguire deleted the patch-1 branch July 19, 2022 15:00

aglitke mentioned this pull request Dec 13, 2022

Add cinder to known provisioners kubevirt/containerized-data-importer#2507

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cinder conditionally supports ReadWriteMany volumes #34219

Cinder conditionally supports ReadWriteMany volumes #34219

jdmaguire commented Jun 10, 2022 •

edited

Loading

linux-foundation-easycla bot commented Jun 10, 2022 •

edited

Loading

k8s-ci-robot commented Jun 10, 2022

netlify bot commented Jun 10, 2022 •

edited

Loading

sftim commented Jun 12, 2022

xing-yang Jul 7, 2022 •

edited

Loading

jdmaguire Jul 11, 2022

xing-yang commented Jul 12, 2022

k8s-ci-robot commented Jul 12, 2022

kbhawkey commented Jul 16, 2022

kbhawkey commented Jul 16, 2022

k8s-ci-robot commented Jul 16, 2022

Cinder conditionally supports ReadWriteMany volumes #34219

Cinder conditionally supports ReadWriteMany volumes #34219

Conversation

jdmaguire commented Jun 10, 2022 • edited Loading

linux-foundation-easycla bot commented Jun 10, 2022 • edited Loading

k8s-ci-robot commented Jun 10, 2022

netlify bot commented Jun 10, 2022 • edited Loading

✅ Pull request preview available for checking

sftim commented Jun 12, 2022

xing-yang Jul 7, 2022 • edited Loading

Choose a reason for hiding this comment

jdmaguire Jul 11, 2022

Choose a reason for hiding this comment

xing-yang commented Jul 12, 2022

k8s-ci-robot commented Jul 12, 2022

kbhawkey commented Jul 16, 2022

kbhawkey commented Jul 16, 2022

k8s-ci-robot commented Jul 16, 2022

jdmaguire commented Jun 10, 2022 •

edited

Loading

linux-foundation-easycla bot commented Jun 10, 2022 •

edited

Loading

netlify bot commented Jun 10, 2022 •

edited

Loading

xing-yang Jul 7, 2022 •

edited

Loading