Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes regarding removals and deprecations #34281

Closed
wants to merge 1 commit into from
Closed

Changes regarding removals and deprecations #34281

wants to merge 1 commit into from

Conversation

nitishfy
Copy link
Member

Fix: #34144

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mrbobbytables after the PR has been reviewed.
You can assign the PR to them by writing /assign @mrbobbytables in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 14, 2022
@netlify
Copy link

netlify bot commented Jun 14, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fdecff2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62a87cc1b0c3bd0008cfce30
😎 Deploy Preview https://deploy-preview-34281--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nitishfy
Copy link
Member Author

Hey @sftim , Please feel free to go through the changes I"ve added regarding the issue mentioned

@zacharysarah
Copy link
Contributor

zacharysarah commented Jun 17, 2022 •
edited
Loading

@nitishkumar06 Please request feedback first from the PR wrangler for the week.

It's great that you're enthusiastic, but the PR wrangler role exists to keep review workloads sustainable. Please do your part to keep this community healthy.

zacharysarah
zacharysarah suggested changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitishkumar06 I think this PR can work if you remove the line rather than replace it.

content/en/blog/_posts/2022-04-07-Kubernetes-1-24-removals-and-deprecations.md
@@ -69,7 +69,7 @@ been deprecated. These removals have been superseded by newer, stable/generally

* [Dynamic kubelet configuration](https://github.com/kubernetes/enhancements/issues/281): `DynamicKubeletConfig` is used to enable the dynamic configuration of the kubelet. The `DynamicKubeletConfig` flag was deprecated in Kubernetes 1.22. In v1.24, this feature gate will be removed from the kubelet. See [Reconfigure kubelet](/docs/tasks/administer-cluster/reconfigure-kubelet/). Refer to the ["Dynamic kubelet config is removed" KEP](https://github.com/kubernetes/enhancements/issues/281) for more information.
* [Dynamic log sanitization](https://github.com/kubernetes/kubernetes/pull/107207): The experimental dynamic log sanitization feature is deprecated and will be removed in v1.24. This feature introduced a logging filter that could be applied to all Kubernetes system components logs to prevent various types of sensitive information from leaking via logs. Refer to [KEP-1753: Kubernetes system components logs sanitization](https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1753-logs-sanitization#deprecation) for more information and an [alternative approach](https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1753-logs-sanitization#alternatives=).
* In-tree provisioner to CSI driver migration: This applies to a number of in-tree plugins, including [Portworx](https://github.com/kubernetes/enhancements/issues/2589). Refer to the [In-tree Storage Plugin to CSI Migration Design Doc](https://git.k8s.io/design-proposals-archive/storage/csi-migration.md#background-and-motivations) for more information.
* In-tree provisioner to CSI driver migration: This applies to a number of in-tree plugins, including [Portworx](https://github.com/kubernetes/enhancements/issues/2589). Refer to the [In-tree Storage Plugin to CSI Migration Design Doc](https://git.k8s.io/design-proposals-archive/storage/csi-migration.md#background-and-motivations) for more information. _Please note that the following content was written with the assumption that [Portworx](https://git.k8s.io/design-proposals-archive/storage/csi-migration.md#background-and-motivations) will be able to target Beta in 1.24. However, [Portworx](https://git.k8s.io/design-proposals-archive/storage/csi-migration.md#background-and-motivations) didn't make it, so it stayed in Alpha in 1.24.There are several practices going on with [Portworx](https://git.k8s.io/design-proposals-archive/storage/csi-migration.md#background-and-motivations) to target Beta again in 1.25._
Copy link
Contributor

@zacharysarah zacharysarah Jun 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope of #34144 is to remove the section, rather than replace it. The replacement text provides more detail than seems helpful.

Additionally, the style guide standard is to use present tense and simple, direct language.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zacharysarah Do you want to remove the whole paragraph at line 72 or just the new changes only that I've added?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @zacharysarah 's comment

The scope of #34144 is to remove the section, rather than replace it. The replacement text provides more detail than seems helpful.

Additionally, the style guide standard is to use present tense and simple, direct language.

Please remove the following section:

In-tree provisioner to CSI driver migration: This applies to a number of in-tree plugins, including Portworx. Refer to the In-tree Storage Plugin to CSI Migration Design Doc for more information.

@sftim
Copy link
Contributor

sftim commented Jun 17, 2022

With the risk of confusion here, I recommend that this update gets review from the blog team even though it is a fixup.

/hold
A blog editor or reviewer (or a SIG Docs chair or tech lead) can remove this hold.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2022
@nitishfy nitishfy mentioned this pull request Jul 14, 2022
Closed
9 tasks
@Sea-n
Copy link
Member

Sea-n commented Aug 3, 2022

CC @mickeyboxell, the author of this post:

Would you like to take a look? Thanks.

@reylejano
Copy link
Member

I'm closing this PR based on mine and zacharysarah's comments that this PR does not address the scope of issue #34144 which is to remove the section not add to it
Feel free to re-open this PR and update the PR to remove the section as stated in issue #34144
/close

@k8s-ci-robot
Copy link
Contributor

@reylejano: Closed this PR.

In response to this:

I'm closing this PR based on mine and zacharysarah's comments that this PR does not address the scope of issue #34144 which is to remove the section not add to it
Feel free to re-open this PR and update the PR to remove the section as stated in issue #34144
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nitishfy
Copy link
Member Author

@reylejano I'll be raising a new PR which shall be focused upon removing the following paragraph.

@nitishfy nitishfy deleted the Nitish/removal_and_deprecations branch August 18, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reylejano reylejano reylejano left review comments

@zacharysarah zacharysarah zacharysarah requested changes

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@sftim sftim Awaiting requested review from sftim

Assignees
No one assigned
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Section regarding Portworx in-tree plugin deprecation should be removed from blog
6 participants
@nitishfy @k8s-ci-robot @zacharysarah @sftim @Sea-n @reylejano