Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downward API concept made Correct #34422

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Downward API concept made Correct #34422

merged 1 commit into from
Jun 20, 2022

Conversation

nitishfy
Copy link
Member

Fix: #34421

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 20, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 20, 2022
@netlify
Copy link

netlify bot commented Jun 20, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit bf59d41
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62b06853f8a4c300080c386c
😎 Deploy Preview https://deploy-preview-34422--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Jun 20, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fbed4c68cdeb09a4b5642fdeec36cf443a1736cc

@tengqm
Copy link
Contributor

tengqm commented Jun 20, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit d3df73a into kubernetes:main Jun 20, 2022
@nitishfy nitishfy mentioned this pull request Jul 14, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Downward API concept has poor hyphenation, harming localization
3 participants
@nitishfy @tengqm @k8s-ci-robot