resource-usage-monitoring.md Modified #34471
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Would you be willing to set a different PR title and PR description? The PR description should explain what's being fixed / added, and why. The title should try to summarize that description. |
| @@ -59,8 +59,11 @@ Autoscaler. The monitoring pipeline fetches metrics from the kubelet and | |||
| then exposes them to Kubernetes via an adapter by implementing either the | |||
| `custom.metrics.k8s.io` or `external.metrics.k8s.io` API. | |||
|
|
|||
| [Prometheus](https://prometheus.io), a CNCF project, can natively monitor Kubernetes, nodes, and Prometheus itself. | |||
| Full metrics pipeline projects that are not part of the CNCF are outside the scope of Kubernetes documentation. | |||
| Kubernetes is designed to work with [OpenMetrics](https://openmetrics.io/) which is one of the CNCF Project. | |||
There was a problem hiding this comment.
👋 @nitishkumar06 . What do you think about these edits:
Kubernetes is designed to work with OpenMetrics which is one of the CNCF Observability and Analysis - Monitoring Projects. Full metrics pipeline projects that are not part of the CNCF are outside the scope of the Kubernetes documentation.
| To know more about the Projects under CNCF, refer to this [link](https://landscape.cncf.io/card-mode?category=monitoring&project=graduated,incubating,member,no&grouping=category&sort=stars). Full metrics pipeline | ||
| projects that are not part of the CNCF are outside the scope of Kubernetes documentation. | ||
|
|
||
| *It is to be noted that Kubernetes Project don't provide any kind of recommendation for other projects to work upon. It is a user choice to pick a project to start working upon. In order to make a Full metric pipeline, Kubernetes is required to design and deploy the infrastructure.* |
There was a problem hiding this comment.
The last two sentences are not as clear, especially the last sentence.
There was a problem hiding this comment.
@kbhawkey What according to you shall a good understandable sentence look like?
There was a problem hiding this comment.
I agree with @kbhawkey, these sentences are not clear and concise
|
I'm closing this PR since there's no traction and there are sentences proposed in this PR that are not clear. |
|
@reylejano: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix: #31483
The following changes have been made looking at @sftim comment to the following issue.
In the section "Full metrics pipeline" it says:
Prometheus, a CNCF project, can natively monitor Kubernetes, nodes, and Prometheus itself. Full metrics pipeline projects that are not part of the CNCF are outside the scope of Kubernetes documentation.
The following paragraph was not appealing much to the reader especially mentioning Prometheus. The purpose of this PR is to ensure the reader that the Kubernetes Project is designed to work with OpenMetrics which is a CNCF Project but K8s doesn't provide any recommendations of other Projects to work upon.