Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] sync the documents using comment #35890

Merged
merged 1 commit into from
Sep 1, 2022
Merged

[ko] sync the documents using comment #35890

merged 1 commit into from
Sep 1, 2022

Conversation

bconfiden2
Copy link
Member

resolves blank issue from #35423 (comment)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 12, 2022
@k8s-ci-robot k8s-ci-robot requested a review from jmyung August 12, 2022 04:47
@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Aug 12, 2022
@k8s-ci-robot k8s-ci-robot requested a review from pjhwa August 12, 2022 04:47
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 12, 2022
@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 40bc0a1
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/63102f8559d938000856993d
😎 Deploy Preview https://deploy-preview-35890--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Member

@bconfiden2 Thank you for the contribution!! :)

This PR includes changes to many files.
May incur conflicts to ongoing other PRs related with #35802 :)

/hold

IMO, this PR would be better to be merged after #35802 is resolved. And, all conflicts can be resolved in this PR.
@bconfiden2 could you accept this opinion ? :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2022
@seokho-son
Copy link
Member

@bconfiden2
By the way, is this PR based on a script (automation) ? :)

@bconfiden2
Copy link
Member Author

@seokho-son It is based on script, but very hard-coded.. 😅 😅
I agree with your opinion about conflicts!
But just in case, it would be better to remind others that there is no need to modify it!!

@seokho-son
Copy link
Member

/assign @seokho-son

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 29, 2022
@seokho-son
Copy link
Member

@bconfiden2
Outdated 처리는 대략 완료가 되어서, 이제 이 PR을 처리하면 어떨까 싶습니다!! :)
Conflicting file 이 하나 추가되어 있어서 해당 conflict만 해결해주시면
바로 승인하면 어떨까 싶습니다! (@bconfiden2 님을 믿고~ 특별히 추가적인 확인은 하지 않으려 합니다. ㅎㅎ)

Netlify build 오류는 정체 불명이므로 ㅎㅎ 커밋에 변화가 생기면.. 아마도 정상적으로 build될 것이라 예상합니다. (신경쓰지마셔용)

@seokho-son
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2022
@bconfiden2
Copy link
Member Author

@seokho-son rebase하여서 충돌 해결하였고, netlify 도 정상적으로 빌드 되었습니다!!
웬만해서 reviewer/approver 가 존재하던 파일들은 다 수정했다고 생각하지만, 만약 빠진 경우에는 그때그때 작업자가 추가하는 방식으로 하면 될 것 같습니다!! 🙇 🙇

@seokho-son
Copy link
Member

@bconfiden2 감사합니다!!!

ko/docs/contribute/localization_ko/#리뷰어-삭제
에 가이드도 업데이트하면 좋을 것 같습니다!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a28e3685e2ea5c6079e11d335877815a700237ba

@seokho-son
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 58828a7 into kubernetes:dev-1.24-ko.3 Sep 1, 2022
@bconfiden2 bconfiden2 deleted the 0812-batch branch March 21, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmyung jmyung Awaiting requested review from jmyung

@pjhwa pjhwa Awaiting requested review from pjhwa

Assignees

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bconfiden2 @seokho-son @k8s-ci-robot