-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use IPv6 Address Prefix Reserved for Documentation #36683
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks @aojea
LGTM label has been added. Git tree hash: 173658239fee96f6e76d4b870ec77d95ef133a83
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted one regression.
@@ -307,8 +307,8 @@ For IPv6 setup, search path and name server should be set up like this: | |||
kubectl exec -it dns-example -- cat /etc/resolv.conf | |||
``` | |||
The output is similar to this: | |||
``` | |||
nameserver fd00:79:30::a | |||
```shell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a valid shell script. Please use the original ``` line as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/approve
LGTM label has been added. Git tree hash: 93aae76b234e7a80ebba3ab208ce84d7cac817a1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Per https://www.rfc-editor.org/rfc/rfc3849.html
The prefix allocated for documentation purposes is 2001:DB8::/32
use some subnet within the range for our API docs
/kind cleanup
/kind documentation