Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote CronJobTimeZone to stable #39835

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Promote CronJobTimeZone to stable #39835

merged 1 commit into from
Mar 20, 2023

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Mar 7, 2023

@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 7, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Mar 7, 2023
@k8s-ci-robot k8s-ci-robot requested review from kbhawkey and sftim March 7, 2023 12:09
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2023
soltysh
soltysh commented Mar 7, 2023
View reviewed changes
content/en/docs/concepts/workloads/controllers/cron-jobs.md
@@ -183,7 +181,7 @@ Specifying a timezone that way is **not officially supported** (and never has be

If you try to set a schedule that includes `TZ` or `CRON_TZ` timezone specification,
Kubernetes reports a [warning](/blog/2020/09/03/warnings/) to the client.
Future versions of Kubernetes might not implement that unofficial timezone mechanism at all.
Future versions of Kubernetes will prevent setting the unofficial timezone mechanism entirely.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim in preparation to land kubernetes/kubernetes#116252 I've changed this wording to be stronger.

This was referenced Mar 7, 2023
Closed
Merged
sftim
sftim reviewed Mar 7, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts. Basically LGTM. The feature gates page fixes are particularly relevant IMO.

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
@@ -251,6 +249,9 @@ For a reference to old feature gates that are removed, please refer to
| `CSIStorageCapacity` | `true` | Beta | 1.21 | 1.23 |
| `CSIStorageCapacity` | `true` | GA | 1.24 | - |
| `ConsistentHTTPGetHandlers` | `true` | GA | 1.25 | - |
| `CronJobTimeZone` | `false` | Alpha | 1.24 | 1.24 |
| `CronJobTimeZone` | `true` | Beta | 1.25 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `CronJobTimeZone` | `true` | Beta | 1.25 | |
| `CronJobTimeZone` | `true` | Beta | 1.25 | 1.26 |

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
@@ -251,6 +249,9 @@ For a reference to old feature gates that are removed, please refer to
| `CSIStorageCapacity` | `true` | Beta | 1.21 | 1.23 |
| `CSIStorageCapacity` | `true` | GA | 1.24 | - |
| `ConsistentHTTPGetHandlers` | `true` | GA | 1.25 | - |
| `CronJobTimeZone` | `false` | Alpha | 1.24 | 1.24 |
| `CronJobTimeZone` | `true` | Beta | 1.25 | |
| `CronJobTimeZone` | `true` | GA | 1.247| - |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `CronJobTimeZone` | `true` | GA | 1.247| - |
| `CronJobTimeZone` | `true` | GA | 1.27 | - |

content/en/docs/concepts/workloads/controllers/cron-jobs.md Outdated
Comment on lines 165 to 168
For CronJobs with no time zone specified, the {{< glossary_tooltip term_id="kube-controller-manager" text="kube-controller-manager" >}}
interprets schedules relative to its local time zone.

{{< feature-state for_k8s_version="v1.25" state="beta" >}}
{{< feature-state for_k8s_version="v1.27" state="stable" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For stable, move the feature state shortcode just under the heading, and put the detail about CronJobs with no time zone specified into a note callout later on in the Time zones section.

Consider moving the caution callout about TZ / CRON_TZ to be the first item in CronJob limitations, and if you want you can hyperlink to that from somewhere within the Time zones section. We're really framing that now as a shortcoming rather than anything close to a feature.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the feature state should be under the Time zones section and not under the CronJob main heading, right?

@soltysh
Copy link
Contributor Author

soltysh commented Mar 17, 2023

@sftim I hope I addressed all the comments as you wished, ptal

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2023
@sftim
Copy link
Contributor

sftim commented Mar 17, 2023

Looks ready for tech review.

@soltysh
Copy link
Contributor Author

soltysh commented Mar 17, 2023

/assign @atiratree
for tech review from sig-apps

@tengqm
Copy link
Contributor

tengqm commented Mar 18, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atiratree
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ef2c02c0e6500f2237577b4e871ef424aee634c7

@k8s-ci-robot k8s-ci-robot merged commit e2526aa into kubernetes:dev-1.27 Mar 20, 2023
@soltysh soltysh deleted the cronjob_tz_ga branch March 20, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@atiratree atiratree atiratree left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees

@atiratree atiratree

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
5 participants
@soltysh @sftim @tengqm @k8s-ci-robot @atiratree