Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preempt registry freeze announcement with redirect announcement #39915

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

BenTheElder
Copy link
Member

This replaces the k8s.gcr.io freeze announcement with a k8s.gcr.io redirect announcement ref #39895

Holding for approval from other steering members and reviews from everyone
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2023
@mrbobbytables
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5b25b025895161fa4c73acede4174df718e8bf15

@BenTheElder BenTheElder changed the title [WIP] preempt registry freeze announcement with redirect announcement preempt registry freeze announcement with redirect announcement Mar 10, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2023
@netlify
Copy link

netlify bot commented Mar 10, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0e6a3b0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/640b8343ab03de000893a63f
😎 Deploy Preview https://deploy-preview-39915--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tpepper
Copy link
Member

tpepper commented Mar 10, 2023

/lgtm

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
(Steering)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0d888eb into kubernetes:main Mar 10, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better late than not?

k8s.gcr.io image registry has been frozen on the 3rd of April 2023.<br/>
Images for Kubernetes 1.27 are not available in the k8s.gcr.io image registry.<br/>
Please read our [announcement](/blog/2023/02/06/k8s-gcr-io-freeze-announcement/) for more details.
k8s.gcr.io image registry will be redirected to registry.k8s.io on Monday March 20th.<br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
k8s.gcr.io image registry will be redirected to registry.k8s.io on Monday March 20th.<br>
k8s.gcr.io image registry is being redirected to registry.k8s.io (since Monday March 20th).<br>

Please read our [announcement](/blog/2023/02/06/k8s-gcr-io-freeze-announcement/) for more details.
k8s.gcr.io image registry will be redirected to registry.k8s.io on Monday March 20th.<br>
All images available in k8s.gcr.io are available at registry.k8s.io.</br>
Please read our [announcement](blog/2023/03/10/image-registry-redirect/) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please read our [announcement](blog/2023/03/10/image-registry-redirect/) for more details.
Please read our [announcement](/blog/2023/03/10/image-registry-redirect/) for more details.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thankfully the current link appears to work in my browser at least, even if non-idiomatic. phew. #39918 contains this and your other suggestions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for https://k8s.io/ but not for other pages.

message: |
k8s.gcr.io image registry will be redirected to registry.k8s.io on Monday March 20th.<br>
All images available in k8s.gcr.io are available at registry.k8s.io.</br>
Please read our [announcement](blog/2023/03/10/image-registry-redirect/) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please read our [announcement](blog/2023/03/10/image-registry-redirect/) for more details.
Please read our [announcement](/blog/2023/03/10/image-registry-redirect/) for more details.

@BenTheElder
Copy link
Member Author

thanks @sftim, will push a follow-up shortly.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late /lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants