-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify recommended Windows hardware requirements #42518
Specify recommended Windows hardware requirements #42518
Conversation
Welcome @tzifudzi! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/sig windows |
Hello @tzifudzi . |
0aea3b8
to
4cef251
Compare
4cef251
to
5c444a1
Compare
Hi @kbhawkey. PR is ready for review. I also applied your suggestion to format the README so that the paraphs stick within the line character limit. |
Ping Sig Windows for technical review /sig windows |
@tzifudzi - Are we seeing cases where people are running into issues with running Windows workloads in Kubernetes specifically because their nodes don't have enough resources? If that is the case perhaps we should add or link to docs that can help easily identify these sorts of issues? |
To my knowledge, there haven't been cases of issues specifically linked to inadequate resources for Windows workloads on Kubernetes. The recommendation to update the documentation I can't recall but I think it originated from the sig-docs team, as reflected in the creation of the parent issue (#31428) that you own. This documentation addresses one of the tasks outlined in that issue. @marosset If we feel the documentation is unnecessary I am ok with closing the issue, but what I suggest is merging, but I can remove the explicit info I specified which could become stale. |
b4359be
to
21df181
Compare
21df181
to
3ed6fad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: d87ac72d7ab28282d5625ffa156a0c243812d1f9
|
3ed6fad
to
45e961a
Compare
45e961a
to
f92b564
Compare
Thank you for addressing comments |
LGTM label has been added. Git tree hash: fb82ddd6d7a3e5b0e9d54589793a25aeaa227850
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant, mloskot, reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What will change
Why this change is necessary?
Documentation
Worker Node Hardware Recommendations
. Navigate using ...staging.netlify.app/docs/concepts/windows/intro/#windows-node-hardware-recommendations to more quickly navigate to the preview