Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blog page footer #42969

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Fix blog page footer #42969

merged 1 commit into from
Sep 9, 2023

Conversation

priyanshuchaudhary53
Copy link
Contributor

Fixes #42967

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 8, 2023
@netlify
Copy link

netlify bot commented Sep 8, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4e0f28e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64fb80286a047f000868005e
😎 Deploy Preview https://deploy-preview-42969--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Sep 9, 2023
dipesh-rawat
dipesh-rawat reviewed Sep 9, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does effectively resolves the whitespace issue in the blog page footer (both for desktop and mobile layouts). Thanks!
/lgtm

Deploy Preview: deploy-preview-42969-blog

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 44c5d7423315e81cfc0f23a776a5e5d81830c5d5

@sftim
Copy link
Contributor

sftim commented Sep 9, 2023

/approve

Thanks for the fix

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0720978 into kubernetes:main Sep 9, 2023
@aj11anuj
Copy link
Member

Hello hello, i can still see a white space line in this page too, but that's present in whole page and not just in footer.. that may be an entire different issue (similar to #42795) due to which it's happening. See again that deploy preview with zoom out screen @dipesh-rawat
Screenshot_2023-09-11-19-29-14-862_org mozilla firefox

Screenshot_2023-09-11-19-29-19-737_org mozilla firefox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees

@dipesh-rawat dipesh-rawat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blog page footer has whitespaces on both sides
5 participants
@priyanshuchaudhary53 @dipesh-rawat @k8s-ci-robot @sftim @aj11anuj