Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a mistake in Secrets concept #43520

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Fix a mistake in Secrets concept #43520

merged 1 commit into from
Jan 1, 2024

Conversation

luoxiaohi
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2023
windsonsea
windsonsea reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tell why this is a mistake in this PR's desc. Do not leave it blank.

image

@netlify
Copy link

netlify bot commented Oct 17, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit aa7cbee
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/652e4cb4cbaca60008ecd20d
😎 Deploy Preview https://deploy-preview-43520--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@luoxiaohi
Copy link
Contributor Author

Please tell why this is a mistake in this PR's desc. Do not leave it blank.

this section is talking about the kubernetes.io/tls Secret type, but its content mistakenly refers to kubernetes.io/ssh-auth, which is described in the previous section.

@sftim
Copy link
Contributor

sftim commented Nov 22, 2023

@luoxiaohi would you be willing to edit the existing description for this PR? That will help reviewers.

kbhawkey
kbhawkey reviewed Dec 21, 2023
View reviewed changes
content/en/docs/concepts/configuration/secret.md
@@ -381,7 +381,7 @@ The following YAML contains an example config for a TLS Secret:

The TLS Secret type is provided only for convenience.
You can create an `Opaque` type for credentials used for TLS authentication.
However, using the defined and public Secret type (`kubernetes.io/ssh-auth`)
However, using the defined and public Secret type (`kubernetes.io/tls`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @luoxiaohi .
Do you have any more information on this change? It's not clear that the kubernetes.io/tls Secret type is correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches line 364.

@sftim
Copy link
Contributor

sftim commented Jan 1, 2024

/retitle Fix a mistake in Secrets concept

@k8s-ci-robot k8s-ci-robot changed the title Concepts -> Configuration -> Secrets Fix a mistake Fix a mistake in Secrets concept Jan 1, 2024
sftim
sftim approved these changes Jan 1, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm
/approve

content/en/docs/concepts/configuration/secret.md
@@ -381,7 +381,7 @@ The following YAML contains an example config for a TLS Secret:

The TLS Secret type is provided only for convenience.
You can create an `Opaque` type for credentials used for TLS authentication.
However, using the defined and public Secret type (`kubernetes.io/ssh-auth`)
However, using the defined and public Secret type (`kubernetes.io/tls`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches line 364.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 80608665abf5f18c5942ce4c103561c1ac4522e5

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 13424fd into kubernetes:main Jan 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey kbhawkey left review comments

@windsonsea windsonsea windsonsea left review comments

@sftim sftim sftim approved these changes

@mikedanese mikedanese Awaiting requested review from mikedanese

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luoxiaohi @sftim @k8s-ci-robot @kbhawkey @windsonsea