Docs for Decoupled TaintManager from NodeLifeCycleController (KEP-3902) #43555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
k8s-ci-robot
added
sig/docs
atosatto
force-pushed
the
tec-dev-1.29
branch
from
510a858 to
12951f5
Compare
10 tasks
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d06ed5a12d45dfdbb6dd770acf923ac74621029a
|
atosatto
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Hello @atosatto @yuanchen8911 👋, I see there are some changes to the docs in progress. 👍 Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you! |
tengqm
reviewed
Nov 7, 2023
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
atosatto
force-pushed
the
tec-dev-1.29
branch
from
12951f5 to
ac92d4f
Compare
k8s-ci-robot
removed
the
lgtm
atosatto
force-pushed
the
tec-dev-1.29
branch
from
ac92d4f to
045eceb
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 4d12b29866c2381eaf133bcd221c3fb6c3a7b016
|
k8s-ci-robot
added
the
needs-rebase
atosatto
force-pushed
the
tec-dev-1.29
branch
from
045eceb to
3cce8e0
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
yuanchen8911
approved these changes
Nov 17, 2023
| @@ -726,6 +727,11 @@ Each feature gate is designed for enabling/disabling a specific feature: | |||
| for all workloads. | |||
| The seccomp profile is specified in the `securityContext` of a Pod and/or a Container. | |||
| - `SecurityContextDeny`: This gate signals that the `SecurityContextDeny` admission controller is deprecated. | |||
| - `SeparateTaintEvictionController`: Enables running `TaintEvictionController`, | |||
| that performs [Taint Based Evictions](/docs/concepts/scheduling-eviction/taint-and-toleration/#taint-based-evictions), | |||
There was a problem hiding this comment.
Suggested change
| that performs [Taint Based Evictions](/docs/concepts/scheduling-eviction/taint-and-toleration/#taint-based-evictions), | |
| that performs [Taint-based Evictions](/docs/concepts/scheduling-eviction/taint-and-toleration/#taint-based-evictions), |
| - `SeparateTaintEvictionController`: Enables running `TaintEvictionController`, | ||
| that performs [Taint Based Evictions](/docs/concepts/scheduling-eviction/taint-and-toleration/#taint-based-evictions), | ||
| in a separated controller from `NodeLifecycleController`. When this feature is | ||
| enabled, users can optionally disable Taint Based Eviction setting the |
There was a problem hiding this comment.
Suggested change
| enabled, users can optionally disable Taint Based Eviction setting the | |
| enabled, users can optionally disable Taint-based Eviction by setting the |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 4fd5fcc1e5326b4f7b23e7a1d58379ea79ff0363
|
atosatto
force-pushed
the
tec-dev-1.29
branch
from
3cce8e0 to
0f7995e
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ddbfc89be7ba248894fc34179abb315b5bfd88fc
|
tengqm
reviewed
Nov 21, 2023
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
|
Hello @atosatto @bradtopol @reylejano 👋, Friendly reminder that the deadline to have docs merged is next Tuesday 28th November 2023. If this feature needs documentation and the docs are not ready, the feature may be removed from the milestone. Let me know if you have any questions. Thank you! |
atosatto
force-pushed
the
tec-dev-1.29
branch
from
0f7995e to
394db54
Compare
k8s-ci-robot
removed
the
lgtm
|
@tengqm just pushed another update with the suggested changes, would you mind checking again? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm, yuanchen8911 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c985f97024818b7a660d4521e8304ebbb5819339
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placeholder docs for KEP-3902
Implementation on-going in kubernetes/kubernetes#119208