Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kubeadm install layout break for mobile device #43624

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix Kubeadm install layout break for mobile device #43624

merged 1 commit into from
Oct 24, 2023

Conversation

Community-Programmer
Copy link
Contributor

Fix Issue: #43265
Issue: Code snippet layout at "Kubeadm install" page is causing layout break of page for mobile devices
Changes made:
Added some css for making adjustment in table layout that are under tabs

image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2023
@netlify
Copy link

netlify bot commented Oct 21, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a542d9d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/653747839b7e670008b3330b
😎 Deploy Preview https://deploy-preview-43624--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Gauravpadam
Gauravpadam reviewed Oct 21, 2023
View reviewed changes
assets/scss/_base.scss Outdated Show resolved Hide resolved
Gauravpadam
Gauravpadam reviewed Oct 21, 2023
View reviewed changes
Copy link
Member

@Gauravpadam Gauravpadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the PR

assets/scss/_base.scss Show resolved Hide resolved
Gauravpadam
Gauravpadam reviewed Oct 22, 2023
View reviewed changes
Copy link
Member

@Gauravpadam Gauravpadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tengqm
Copy link
Contributor

tengqm commented Oct 23, 2023

any links for preview?

@Community-Programmer
Copy link
Contributor Author

any links for preview?

Page Changed:
https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/

Preview After Change:
https://deploy-preview-43624--kubernetes-io-main-staging.netlify.app/docs/setup/production-environment/tools/kubeadm/install-kubeadm/

@tengqm
Copy link
Contributor

tengqm commented Oct 23, 2023

@Community-Programmer What was broken (fixed)?

@Community-Programmer
Copy link
Contributor Author

@Community-Programmer What was broken (fixed)?

In this section, the page is broken on mobile devices due to content overflow.

WhatsApp Image 2023-10-23 at 8 55 02 AM (1)

WhatsApp Image 2023-10-23 at 8 55 02 AM

@tengqm
Copy link
Contributor

tengqm commented Oct 23, 2023

@Community-Programmer Alright. Can we enable the horizontal scrolling rather than having the snippets wrapped?

@sftim
Copy link
Contributor

sftim commented Oct 23, 2023

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Oct 23, 2023
@Community-Programmer
Copy link
Contributor Author

Community-Programmer commented Oct 23, 2023 •
edited
Loading

@Community-Programmer Alright. Can we enable the horizontal scrolling rather than having the snippets wrapped?

I've made the necessary changes to enable horizontal scrolling instead of wrapping the snippets.
Please review

@tengqm
Copy link
Contributor

tengqm commented Oct 24, 2023

Please squash the commits and let's see if the tweak actually works.

@tengqm
Copy link
Contributor

tengqm commented Oct 24, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa0319a54fd0754245543fc10b9145d56d650b94

sftim
sftim reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit b6af78d into kubernetes:main Oct 24, 2023
@Gauravpadam Gauravpadam mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravpadam Gauravpadam Gauravpadam left review comments

@sftim sftim sftim left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Community-Programmer @tengqm @sftim @k8s-ci-robot @Gauravpadam