Fixed KubeCon NA Banner mobile layout #43625
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Gauravpadam
force-pushed
the
Fix-KubeCon-NA-Banner-css
branch
from
d8484eb to
3096a08
Compare
| <a href= "https://events.linuxfoundation.org/kubecon-cloudnativecon-north-america/">KubeCon + CloudNativeCon NA 2023</a> <em> Chicago, Illinois + Virtual</em>. | ||
| <a href= "https://events.linuxfoundation.org/kubecon-cloudnativecon-north-america/">KubeCon + CloudNativeCon NA 2023</a> <em> Chicago, Illinois + Virtual</em> |
There was a problem hiding this comment.
That's uncalled for, I'll revert this
There was a problem hiding this comment.
Please do update this PR; ideally, also rebase it against main.
| font-size: 1.5em; | ||
|
|
||
| img { | ||
| order: 2; |
There was a problem hiding this comment.
How do we know this value is correct?
There was a problem hiding this comment.
I see the problem here, I'll figure something out
| display: flex; | ||
| flex-direction: column; | ||
| text-align: center; |
There was a problem hiding this comment.
How do we know this is right (for every future announcement)?
There was a problem hiding this comment.
column flex would work well with small viewports, I'd like to know your thoughts on this
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @Gauravpadam , since this PR has needed a rebase for more than a few months, I'm closing this PR for now. |
|
@reylejano: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closes #43622
This fix should work for other announcements as well