Add user guidance comment for executing drain and uncordon on control plane #44322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
language/en
|
/assign |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
neolit123
reviewed
Dec 13, 2023
content/en/docs/tasks/administer-cluster/kubeadm/upgrading-linux-nodes.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/administer-cluster/kubeadm/upgrading-linux-nodes.md
Outdated
Show resolved
Hide resolved
k8s-ci-robot
added
sig/cluster-lifecycle
change this to |
… commands must be executed on a control plane node. Apply suggestions from code review Co-authored-by: Lubomir I. Ivanov <[email protected]>
adityasamant25
force-pushed
the
issue-44321
branch
from
598d0a6 to
3a13717
Compare
|
@neolit123 Thanks for your feedback. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 4238ab9fed0d223615d1415e94b3a87f57be9269
|
|
/retitle Add user guidance comment for executing drain and uncordon on control plane |
k8s-ci-robot
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divya-mohan0209 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44321
Added clear comments to specify that the
kubectl drainandkubectl uncordoncommands must be executed on the controlplane node.Suggestions and feedback are welcome.
Best Regards,
Aditya