Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize contributions other than docs #44559

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Dec 28, 2023

There are lots of ways to get involved. Make it easier to discover what those are.

I opened this PR to show my alternative take on the change proposed in #43948.

/label refactor

There are lots of ways to get involved. Make it easier to discover what
those are.
@k8s-ci-robot k8s-ci-robot added refactor Indicates a PR with large refactoring changes e.g. removes files or moves content cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 28, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 28, 2023
@sftim
Copy link
Contributor Author

sftim commented Dec 28, 2023

@corneliusroemer what do you think?

Copy link

netlify bot commented Dec 28, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 77857bc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/658d8aa4acaa4300088f9077
😎 Deploy Preview https://deploy-preview-44559--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stmcginnis
Copy link
Contributor

/lgtm

Definite improvement, IMO.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6294ccf65b6a98da652a178b6048a17456f64783

@reylejano
Copy link
Member

Wonderful improvement
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit a818f22 into kubernetes:main Jan 2, 2024
6 checks passed
@sftim sftim deleted the 20231228_emphasize_non_docs_contributions branch January 3, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. refactor Indicates a PR with large refactoring changes e.g. removes files or moves content sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants